Attachment 173406 Details for Bug 36822 – Bug 36822: LDAP - Add discard_changes

[patch] Bug 36822: LDAP - Add discard_changes

Bug-36822-LDAP---Add-discardchanges.patch (text/plain), 1.22 KB, created by David Nind on 2024-10-25 18:03:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-25 18:03:00 UTC

Size: 1.22 KB

patch

obsolete

>From 590e8b3f69cc3d115632e933fcb5e511222350ef Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 25 Oct 2024 14:41:56 +0000
>Subject: [PATCH] Bug 36822: LDAP - Add discard_changes
>
>Test plan:
>1) Apply only LDAP rearrangement patch
>2) Run that test file (to prove the rearrangement does not break tests):
>$ prove t/db_dependent/Auth_with_ldap.t
>3) Verify tests pass
>4) Apply LDAP test patch on top
>5) Run the test file. Notice it fails.
>6) Apply this patch. Run LDAP tests again. Verify tests pass.
>
>Co-authored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/Auth_with_ldap.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
>index f0993c89ba..406e0d9a19 100644
>--- a/C4/Auth_with_ldap.pm
>+++ b/C4/Auth_with_ldap.pm
>@@ -227,6 +227,7 @@ sub checkpw_ldap {
>                 map { exists( $borrower{$_} ) ? ( $_ => $borrower{$_} ) : () } @columns
>             }
>         )->store;
>+        $patron->discard_changes;
>         die "Insert of new patron failed" unless $patron;
>         $borrowernumber = $patron->borrowernumber;
>         C4::Members::Messaging::SetMessagingPreferencesFromDefaults(
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 36822: 173373 | 173374 | 173375 | 173376 | 173377 | 173385 | 173386 | 173387 | 173388 | 173389 | 173391 | 173392 | 173393 | 173394 | 173395 | 173402 | 173403 | 173404 | 173405 | 173406 | 173646 | 173903 | 173904 | 173905 | 173906 | 173907 | 173908 | 173909 | 174523 | 174525 | 174926 | 174927 | 174965