Bugzilla – Attachment 173452 Details for
Bug 33484
Ability to remember user's selected table configuration and search filters for tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33484: Add tables_settings.default_save_state_search
Bug-33484-Add-tablessettingsdefaultsavestatesearch.patch (text/plain), 4.52 KB, created by
Jonathan Druart
on 2024-10-28 09:44:51 UTC
(
hide
)
Description:
Bug 33484: Add tables_settings.default_save_state_search
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-10-28 09:44:51 UTC
Size:
4.52 KB
patch
obsolete
>From c343a96200d77a6154e5a8824767e85ff182e74b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 3 Oct 2024 10:44:01 +0200 >Subject: [PATCH] Bug 33484: Add tables_settings.default_save_state_search > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > admin/columns_settings.yml | 3 +++ > installer/data/mysql/atomicupdate/bug_33484.pl | 7 +++++++ > installer/data/mysql/kohastructure.sql | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 3 +-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 1 - > 5 files changed, 12 insertions(+), 3 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index 5b441fbb1e5..e318746cb7f 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -116,6 +116,7 @@ modules: > > parcel: > pending_orders: >+ default_save_state_search: 1 > columns: > - > columnname: checkbox >@@ -213,6 +214,7 @@ modules: > > suggestions: > suggestions: >+ default_save_state_search: 1 > columns: > - > columnname: selections >@@ -1960,6 +1962,7 @@ modules: > circ-overdues: > default_display_length: 20 > default_sort_order: 0 >+ default_save_state_search: 1 > columns: > - > columnname: due_date >diff --git a/installer/data/mysql/atomicupdate/bug_33484.pl b/installer/data/mysql/atomicupdate/bug_33484.pl >index a99d3a55d17..29f1102413d 100755 >--- a/installer/data/mysql/atomicupdate/bug_33484.pl >+++ b/installer/data/mysql/atomicupdate/bug_33484.pl >@@ -13,5 +13,12 @@ return { > }); > say $out "Added column 'tables_settings.default_save_state'"; > } >+ if ( !column_exists( 'tables_settings', 'default_save_state_search' ) ) { >+ $dbh->do(q{ >+ ALTER TABLE tables_settings >+ ADD COLUMN default_save_state_search tinyint(1) DEFAULT 0 AFTER default_save_state >+ }); >+ say $out "Added column 'tables_settings.default_save_state_search'"; >+ } > }, > }; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 9675680e976..718565cddef 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -6239,6 +6239,7 @@ CREATE TABLE `tables_settings` ( > `default_display_length` smallint(6) DEFAULT NULL, > `default_sort_order` varchar(255) DEFAULT NULL, > `default_save_state` tinyint(1) DEFAULT 1, >+ `default_save_state_search` tinyint(1) DEFAULT 0, > PRIMARY KEY (`module`(191),`page`(191),`tablename`(191)) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > /*!40101 SET character_set_client = @saved_cs_client */; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index ee605f66d63..5257c3dcc4a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -374,7 +374,7 @@ > > if ( $("#receivedt").length ) { > var receivedt = $("#receivedt").dataTable($.extend(true, {}, dataTablesDefaults, { >- "stateSave": true, >+ "stateSave": true, // We do not have table settings on this table > "pageLength": 10, > "lengthMenu": [[5, 10, 20, 50, 100, -1], [5, 10, 20, 50, 100, _("All")]], > "columnDefs": [ >@@ -413,7 +413,6 @@ > "current_item_level_holds+count", > "items" > ], >- "stateSave": true, // remember state on page reload > "columns": [ > { "data": "basket.name", > "searchable": true, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index f83ad1a9f21..b78a0c302c9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -339,7 +339,6 @@ > KohaTable("overduest", { > "pagingType": "full", > "autoWidth": false, >- "stateSave": true > }, table_settings); > > $("#showall").on("change", function(){ >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33484
:
149444
|
149445
|
149447
|
149448
|
149449
|
149925
|
149926
|
149927
|
149928
|
149929
|
149930
|
149974
|
149975
|
149976
|
149977
|
149978
|
149979
|
173443
|
173444
|
173445
|
173446
|
173447
|
173448
|
173449
|
173450
|
173451
| 173452 |
173453
|
173454
|
173455
|
173456
|
173457
|
173458
|
173459
|
173460
|
173461
|
173462
|
173463
|
173464
|
173465
|
173466
|
173467
|
173468
|
173469
|
173470
|
173471
|
173472
|
173473
|
173474
|
173475
|
173476
|
173477
|
173478
|
173479
|
173480
|
173481
|
173482
|
173483
|
173484
|
173485
|
173486
|
173546
|
173606
|
173607
|
173985
|
174219