Attachment 173464 Details for Bug 33484 – Bug 33484: Early return in add_filters if node does not exist

[patch] Bug 33484: Early return in add_filters if node does not exist

Bug-33484-Early-return-in-addfilters-if-node-does-.patch (text/plain), 1.19 KB, created by Jonathan Druart on 2024-10-28 09:45:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-10-28 09:45:35 UTC

Size: 1.19 KB

patch

obsolete

>From c5f7e5080a575e5a3b0b8a344f01fb7834fe1549 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 8 Oct 2024 11:45:58 +0200
>Subject: [PATCH] Bug 33484: Early return in add_filters if node does not exist
>
>Maybe we could even return early from kohaTable?
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index c560bd729bd..5b7de460846 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -841,6 +841,8 @@ function _dt_on_visibility(add_filters, table_node, table_dt){
> 
> function _dt_add_filters(table_node, table_dt, filters_options = {}) {
> 
>+    if (!table_node.length) return;
>+
>     $(table_node).find('thead tr:eq(1)').remove(); // Remove if one exists already
>     $(table_node).find('thead tr').clone().appendTo( $(table_node).find('thead') );
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33484: 149444 | 149445 | 149447 | 149448 | 149449 | 149925 | 149926 | 149927 | 149928 | 149929 | 149930 | 149974 | 149975 | 149976 | 149977 | 149978 | 149979 | 173443 | 173444 | 173445 | 173446 | 173447 | 173448 | 173449 | 173450 | 173451 | 173452 | 173453 | 173454 | 173455 | 173456 | 173457 | 173458 | 173459 | 173460 | 173461 | 173462 | 173463 | 173464 | 173465 | 173466 | 173467 | 173468 | 173469 | 173470 | 173471 | 173472 | 173473 | 173474 | 173475 | 173476 | 173477 | 173478 | 173479 | 173480 | 173481 | 173482 | 173483 | 173484 | 173485 | 173486 | 173546 | 173606 | 173607 | 173985 | 174219