Bugzilla – Attachment 173475 Details for
Bug 33484
Ability to remember user's selected table configuration and search filters for tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33484: Fix for suggestions
Bug-33484-Fix-for-suggestions.patch (text/plain), 1.59 KB, created by
Jonathan Druart
on 2024-10-28 09:46:16 UTC
(
hide
)
Description:
Bug 33484: Fix for suggestions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-10-28 09:46:16 UTC
Size:
1.59 KB
patch
obsolete
>From 6894f7596990787753acc6914025c46725e90f4b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 17 Oct 2024 09:50:56 +0200 >Subject: [PATCH] Bug 33484: Fix for suggestions > >This ugly fix is retrieving all CGI params and consider them attributes >for suggestions. So we need to exclude other ones... > >There is more to make it works properly on this table. > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > suggestion/suggestion.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 2f6b53970fe..83ec65b230f 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -112,8 +112,10 @@ $suggestion_only->{STATUS} = $suggestion_ref->{STATUS}; > delete $$suggestion_ref{$_} > foreach > qw( suggestedbyme op displayby tabcode notify filter_archived koha_login_context auth_forwarded_hash password userid ); >-foreach (keys %$suggestion_ref){ >- delete $$suggestion_ref{$_} if (!$$suggestion_ref{$_} && ($op eq 'else' )); >+ >+foreach my $key ( keys %$suggestion_ref ) { >+ delete $suggestion_ref->{$key} if ( !$suggestion_ref->{$key} && ( $op eq 'else' ) ); >+ delete $suggestion_ref->{$key} if $key =~ m{^DataTables_acqui_suggestions_suggestions}; > } > delete $suggestion_only->{branchcode} if $suggestion_only->{branchcode} eq '__ANY__'; > delete $suggestion_only->{budgetid} if $suggestion_only->{budgetid} eq '__ANY__'; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33484
:
149444
|
149445
|
149447
|
149448
|
149449
|
149925
|
149926
|
149927
|
149928
|
149929
|
149930
|
149974
|
149975
|
149976
|
149977
|
149978
|
149979
|
173443
|
173444
|
173445
|
173446
|
173447
|
173448
|
173449
|
173450
|
173451
|
173452
|
173453
|
173454
|
173455
|
173456
|
173457
|
173458
|
173459
|
173460
|
173461
|
173462
|
173463
|
173464
|
173465
|
173466
|
173467
|
173468
|
173469
|
173470
|
173471
|
173472
|
173473
|
173474
| 173475 |
173476
|
173477
|
173478
|
173479
|
173480
|
173481
|
173482
|
173483
|
173484
|
173485
|
173486
|
173546
|
173606
|
173607
|
173985
|
174219