Bugzilla – Attachment 173488 Details for
Bug 38257
Several functionalities broken in cart pop up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38257: Fix cart pop up functionalities
0001-Bug-38257-Fix-cart-pop-up-functionalities.patch (text/plain), 1.78 KB, created by
Emmi Takkinen
on 2024-10-28 10:16:00 UTC
(
hide
)
Description:
Bug 38257: Fix cart pop up functionalities
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2024-10-28 10:16:00 UTC
Size:
1.78 KB
patch
obsolete
>From ed37dd29a806b9bbf5f29376fa90afcd98a37dec Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Thu, 24 Oct 2024 14:57:46 +0300 >Subject: [PATCH 1/2] Bug 38257: Fix cart pop up functionalities > >Almost all functionalities in cart pop up were broken >due changes made in bug 37033. Also following errors >were displayed in browsers console: > >> Uncaught TypeError: antiClickjack is null >> Uncaught TypeError: $(...).dataTable is not a function > >This happens because when 'intranet-bottom.inc' is loaded >after other .inc files in page. > >To test: >1. Search for items and add one or more search results to your cart. >2. Open cart. >3. Attempt to use one or more functionalities (download, remove item etc.). >=> Either nothing happens or table is loaded again with no items in >table. However items are still displayed in cart when it's opened again. >4. Apply this patch, restart services if needed. >5. Again attempt to download, remove items, print etc. from cart >=> Everything should now work as expected. > >Sponsored-by: Koha-Suomi Oy >--- > koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >index 03e849c20d..ac25ebad17 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >@@ -355,10 +355,10 @@ > </div> [% # /.row %] > </div> [% # /.main.container-fluid %] > >+ [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] > [% INCLUDE js_includes.inc %] > [% INCLUDE 'datatables.inc' %] > [% Asset.js("js/cart.js") | $raw %] >- [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] > > </body> > </html> >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38257
:
173263
|
173488
|
173489
|
173683
|
173835
|
173836