Bugzilla – Attachment 173490 Details for
Bug 38271
Missing 008 field in bibliographic records created via EDIFACT
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38271: (QA follow-up) Fix testcritic
Bug-38271-QA-follow-up-Fix-testcritic.patch (text/plain), 854 bytes, created by
Matt Blenkinsop
on 2024-10-28 10:27:19 UTC
(
hide
)
Description:
Bug 38271: (QA follow-up) Fix testcritic
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-10-28 10:27:19 UTC
Size:
854 bytes
patch
obsolete
>From df90425cb73c2a051fffe8fe28d1661860cbade0 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Mon, 28 Oct 2024 09:35:04 +0000 >Subject: [PATCH] Bug 38271: (QA follow-up) Fix testcritic > >testcritic was failing due to a 'return undef' so this commit amends that > >Test plan: >1) prove t/00-testcritic.t >--- > t/db_dependent/Koha/EDI.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/EDI.t b/t/db_dependent/Koha/EDI.t >index a82ad168b15..d88b251a7c4 100755 >--- a/t/db_dependent/Koha/EDI.t >+++ b/t/db_dependent/Koha/EDI.t >@@ -260,7 +260,7 @@ subtest '_handle_008_field' => sub { > '_check_for_existing_bib', > sub { > my $bib_record = shift; >- return undef; >+ return; > } > ); > $edi_module->mock( >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38271
:
173347
|
173357
|
173358
|
173442
| 173490