Attachment 173495 Details for Bug 30648 – Bug 30648: Add new field to REST API

[patch] Bug 30648: Add new field to REST API

Bug-30648-Add-new-field-to-REST-API.patch (text/plain), 3.07 KB, created by Martin Renvoize (ashimema) on 2024-10-28 10:31:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-28 10:31:30 UTC

Size: 3.07 KB

patch

obsolete

>From fc1e6a39b03f983946d8892685380407eb8b0fe6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 11 Oct 2024 12:51:52 +0000
>Subject: [PATCH] Bug 30648: Add new field to REST API
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Maybe we just undef it since ti will always be null except for old_hold obecjts
>and we don't have that route yet
>
>Signed-off-by: Anneli Ãsterman <anneli.osterman@koha-suomi.fi>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Hold.pm                         | 37 ++++++++++++++--------------
> api/v1/swagger/definitions/hold.yaml |  3 +++
> 2 files changed, 22 insertions(+), 18 deletions(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index ac3768f0e2b..f5f8ada2b45 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -1027,25 +1027,26 @@ on the API.
> 
> sub to_api_mapping {
>     return {
>-        reserve_id       => 'hold_id',
>-        borrowernumber   => 'patron_id',
>-        reservedate      => 'hold_date',
>-        biblionumber     => 'biblio_id',
>-        branchcode       => 'pickup_library_id',
>-        notificationdate => undef,
>-        reminderdate     => undef,
>-        cancellationdate => 'cancellation_date',
>-        reservenotes     => 'notes',
>-        found            => 'status',
>-        itemnumber       => 'item_id',
>-        waitingdate      => 'waiting_date',
>-        expirationdate   => 'expiration_date',
>+        reserve_id             => 'hold_id',
>+        borrowernumber         => 'patron_id',
>+        reservedate            => 'hold_date',
>+        biblionumber           => 'biblio_id',
>+        deleted_biblionumber   => 'deleted_biblio_id',
>+        branchcode             => 'pickup_library_id',
>+        notificationdate       => undef,
>+        reminderdate           => undef,
>+        cancellationdate       => 'cancellation_date',
>+        reservenotes           => 'notes',
>+        found                  => 'status',
>+        itemnumber             => 'item_id',
>+        waitingdate            => 'waiting_date',
>+        expirationdate         => 'expiration_date',
>         patron_expiration_date => undef,
>-        lowestPriority   => 'lowest_priority',
>-        suspend          => 'suspended',
>-        suspend_until    => 'suspended_until',
>-        itemtype         => 'item_type',
>-        item_level_hold  => 'item_level',
>+        lowestPriority         => 'lowest_priority',
>+        suspend                => 'suspended',
>+        suspend_until          => 'suspended_until',
>+        itemtype               => 'item_type',
>+        item_level_hold        => 'item_level',
>     };
> }
> 
>diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml
>index 85bcd669000..98d4309cca8 100644
>--- a/api/v1/swagger/definitions/hold.yaml
>+++ b/api/v1/swagger/definitions/hold.yaml
>@@ -16,6 +16,9 @@ properties:
>   biblio_id:
>     type: integer
>     description: Internal biblio identifier
>+  deleted_biblio_id:
>+    type: integer
>+    description: Internal deleted biblio identifier
>   item_group_id:
>     type:
>       - string
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 30648: 172687 | 172688 | 172689 | 172690 | 172691 | 172692 | 173340 | 173341 | 173342 | 173343 | 173344 | 173345 | 173491 | 173492 | 173493 | 173494 | 173495 | 173496 | 173611