Bugzilla – Attachment 173497 Details for
Bug 38246
If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38246: Only check unresolved claims
Bug-38246-Only-check-unresolved-claims.patch (text/plain), 1.91 KB, created by
Martin Renvoize (ashimema)
on 2024-10-28 10:35:04 UTC
(
hide
)
Description:
Bug 38246: Only check unresolved claims
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-28 10:35:04 UTC
Size:
1.91 KB
patch
obsolete
>From d4e380cd0eed659a74c7037248eba8855c8d504e Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Wed, 23 Oct 2024 15:33:51 -0400 >Subject: [PATCH] Bug 38246: Only check unresolved claims > >To test: >1. Set up sysprefs: > - Set any non-empty value for ClaimReturnedLostValue > - Set AutoClaimReturnStatusOnCheckout to "found in library" > - Set AutoClaimReturnStatusOnCheckin to "returned by patron" >2. Check out an item to a patron >3. On the patron's account page, click the "Claim Return" button next to > that checkout >4. Check the item in. Note the message that the claim was auto-resolved. >5. Return to the patron's account page and open the Claims Returned tab >--> Note that the claim is resolved and hidden >6. Click the "Show all 1 claims" link to view the hidden claim. Make a > note of the resolution code and timestamp. >7. Check the item out again >--> Note the message saying that the claim was resolved, even though it > was already resolved previously >8. View the return claim again >--> Note that the timestamp and resolution code have changed >9. Apply patch and restart_all >10. Repeat steps 2-8 with a new item >--> Note you do not get a claim resolved message on checkout this time >--> Note that the timestamp and resolution code remain the same before > and after the checkout > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > circ/circulation.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 2ae9447cf61..6839f957f33 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -442,6 +442,7 @@ if (@$barcodes && $op eq 'cud-checkout') { > my $claims = Koha::Checkouts::ReturnClaims->search( > { > itemnumber => $item->id, >+ resolution => undef, > } > ); > if ( $claims->count ) { >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38246
:
173238
|
173239
|
173248
|
173249
| 173497 |
173498
|
175578