Attachment 173504 Details for Bug 38066 – Bug 38066: Popup window footers can block page content

[patch] Bug 38066: Popup window footers can block page content

Bug-38066-Popup-window-footers-can-block-page-cont.patch (text/plain), 2.12 KB, created by Martin Renvoize (ashimema) on 2024-10-28 10:41:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-28 10:41:42 UTC

Size: 2.12 KB

patch

obsolete

>From b7fc8136a78daab982e3d5b1a89606b144f9e6bb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 21 Oct 2024 18:19:07 +0000
>Subject: [PATCH] Bug 38066: Popup window footers can block page content
>
>The staff interface's default <body> padding is enough to accommmodate
>the langugage-selection footer but not the taller fixed footer on pop-up
>window pages. This patch adds some CSS to increase the padding on those
>pages to prevent page content from being obscured by the footer
>navigation.
>
>The patch also adjusts the CSS of the "Back to top" arrow so that it
>isn't hidden by fixed footer.
>
>To test, apply the patch and rebuild the staff interface CSS.
>
>- In the staff client, go to Cataloging -> New record.
>- In tab one, click the plugin button on tag 100 subfield a.
>- Perform an authority search which will return results.
>- Scroll down to the bottom of the window and confirm that the last
>  lines of the search results are not obscured by the footer.
>
>This change should apply to all pop-up windows which include the same
>fixed footer markup, e.g. any cataloging plugin; the transfer order
>window; vendor search when adding a subscription, etc.
>
>Sponsored-by: Athens County Public Libraries
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 6b6c5e7f0c4..611fc240aaf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -736,6 +736,10 @@ body {
>     padding: 0;
>     text-align: left;
> 
>+    &:has( nav.fixed-bottom ) {
>+        padding-bottom: 6rem;
>+    }
>+
>     &.nobackdrop {
>         .modal-backdrop {
>             opacity: 0;
>@@ -4830,7 +4834,7 @@ div .suggestion_note {
>     position: fixed;
>     bottom: 40px;
>     right: 40px;
>-    z-index: 1000;
>+    z-index: $zindex-tooltip;
> }
> 
> @media only screen and ( max-width: 1200px ) {
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 38066: 173079 | 173080 | 173504