Attachment 173514 Details for Bug 38243 – Bug 38243: Remove options.query_parameters

[patch] Bug 38243: Remove options.query_parameters

Bug-38243-Remove-optionsqueryparameters.patch (text/plain), 1.98 KB, created by Martin Renvoize (ashimema) on 2024-10-28 11:09:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-28 11:09:18 UTC

Size: 1.98 KB

patch

obsolete

>From 64d4b1d8d91d7fca2fc1667993c0cf6a2efa4b6e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 23 Oct 2024 16:51:00 +0200
>Subject: [PATCH] Bug 38243: Remove options.query_parameters
>
>This is never passed: `git grep query_parameters`
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js  | 1 -
> koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 3 ---
> 2 files changed, 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index 1b5ee091781..c074ad81d2b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -627,7 +627,6 @@ function _dt_default_ajax (params){
>                 query_parameters = JSON.stringify(query_parameters.length === 1?query_parameters[0]:{"-and": query_parameters});
>                 dataSet.q = query_parameters;
>             }
>-            delete options.query_parameters;
> 
>             dataSet._match = options.criteria;
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/datatables.js b/koha-tmpl/opac-tmpl/bootstrap/js/datatables.js
>index 64d201861cf..d7dc7aec380 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/datatables.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/datatables.js
>@@ -180,9 +180,6 @@ $.fn.dataTable.ext.buttons.clearFilter = {
>                                 if(query_parameters.length) {
>                                     query_parameters = JSON.stringify(query_parameters.length === 1?query_parameters[0]:query_parameters);
>                                     dataSet.q = query_parameters;
>-                                    delete options.query_parameters;
>-                                } else {
>-                                    delete options.query_parameters;
>                                 }
> 
>                                 dataSet._match = options.criteria;
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 38243: 173221 | 173222 | 173234 | 173235 | 173513 | 173514