Bugzilla – Attachment 173525 Details for
Bug 38041
Not all self checkout errors behave the same
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO
Bug-38041-Pass-hidemain-for-all-needsconfirm-warni.patch (text/plain), 1.29 KB, created by
Martin Renvoize (ashimema)
on 2024-10-28 11:49:46 UTC
(
hide
)
Description:
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-28 11:49:46 UTC
Size:
1.29 KB
patch
obsolete
>From 9ed2d1c240e8d15b05b20be99129a66e5a4408d9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 30 Sep 2024 19:54:30 +0000 >Subject: [PATCH] Bug 38041: Pass hide_main for all needsconfirm warnings in > SCO > >To test: >1. APPLY PATCH and restart_all >2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: >DEBT >RENEW_ISSUE >ISSUED_TO_ANOTHER >RESERVED >TRANSFERRED >INVALID_DATE ( cant test in SCO ) >TOO_MANY >RECALLED > >Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/sco/sco-main.pl | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl >index bf923c754f9..25503fe916f 100755 >--- a/opac/sco/sco-main.pl >+++ b/opac/sco/sco-main.pl >@@ -257,6 +257,9 @@ if ( $patron && $op eq "cud-returnbook" && $allowselfcheckreturns ) { > $failed_checkout->{DEBT} = $needconfirm->{DEBT}; > } > push @failed_checkouts, $failed_checkout; >+ $template->param( >+ hide_main => 1, >+ ); > } else { > if ( $confirmed || $issuenoconfirm ) { # we'll want to call getpatroninfo again to get updated issues. > my ( $hold_existed, $item ); >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38041
:
172236
|
172531
| 173525