Attachment 173535 Details for Bug 31224 – Bug 31224: EmbedItems takes an arrayref

[patch] Bug 31224: EmbedItems takes an arrayref

Bug-31224-EmbedItems-takes-an-arrayref.patch (text/plain), 1.15 KB, created by Tomás Cohen Arazi (tcohen) on 2024-10-28 13:08:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-10-28 13:08:24 UTC

Size: 1.15 KB

patch

obsolete

>From 677cd638f061325fd7ba27d301aa02207cf29efa Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 28 Oct 2024 09:53:08 -0300
>Subject: [PATCH] Bug 31224: EmbedItems takes an arrayref
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Biblio.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 8794ff979e6..c972bff3862 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -165,11 +165,11 @@ sub metadata_record {
> 
>         if ( $params->{embed_items} ) {
>             push @filters, 'EmbedItems';
>-            if ( $params->{interface} eq 'opac' ) {
>+            if ( $params->{interface} && $params->{interface} eq 'opac' ) {
>                 $options->{items} = $self->items->filter_by_visible_in_opac(
>-                    { ( $params->{patron} ? ( patron => $params->{patron} ) : () ) } );
>+                    { ( $params->{patron} ? ( patron => $params->{patron} ) : () ) } )->unblessed;
>             } else {
>-                $options->{items} = $self->items;
>+                $options->{items} = $self->items->unblessed;
>             }
>         }
> 
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 31224: 138060 | 138061 | 138062 | 138063 | 138064 | 142137 | 142138 | 142139 | 142140 | 142141 | 142142 | 142143 | 161933 | 161934 | 161935 | 161936 | 161937 | 161938 | 161939 | 161940 | 161941 | 161942 | 161943 | 161944 | 173530 | 173531 | 173532 | 173533 | 173534 | 173535 | 173588 | 173597 | 173598 | 173636 | 173637 | 173638 | 173639 | 173640 | 173641 | 173642 | 173643 | 173644 | 174262 | 174263