Attachment 173601 Details for Bug 35659 – Bug 35659: (QA follow-up) Fix t/db_dependent/Koha/OAIHarvester.t

[patch] Bug 35659: (QA follow-up) Fix t/db_dependent/Koha/OAIHarvester.t

Bug-35659-QA-follow-up-Fix-tdbdependentKohaOAIHarv.patch (text/plain), 1.42 KB, created by David Cook on 2024-10-29 00:48:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2024-10-29 00:48:52 UTC

Size: 1.42 KB

patch

obsolete

>From 69c6fd6701c651632f21d15ffe7464a713e8cbe6 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Tue, 29 Oct 2024 00:43:32 +0000
>Subject: [PATCH] Bug 35659: (QA follow-up) Fix
> t/db_dependent/Koha/OAIHarvester.t
>
>Previously, this test just checked the last 1 day of bib activity,
>but on a fresh test system there will be no activity, so it will always
>fail.
>
>Instead, let's just check that a number is returned for the total,
>even if that total number is 0, since 0 is a valid response too.
>---
> t/db_dependent/Koha/OAIHarvester.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/OAIHarvester.t b/t/db_dependent/Koha/OAIHarvester.t
>index 1a64ed22e2..2bb3cc7741 100755
>--- a/t/db_dependent/Koha/OAIHarvester.t
>+++ b/t/db_dependent/Koha/OAIHarvester.t
>@@ -20,7 +20,8 @@
> use Modern::Perl;
> use Test::More tests => 28;
> use Test::Exception;
>-use File::Temp qw/tempfile/;
>+use File::Temp   qw/tempfile/;
>+use Scalar::Util qw//;
> 
> use t::lib::TestBuilder;
> use t::lib::Mocks;
>@@ -66,7 +67,7 @@ like(
>     'Got list of supported metadata formats'
> );
> is( $init_results->{is_error}, undef, 'ListRecords request worked' );
>-cmp_ok( $init_results->{total}, '>', 0, 'Records have been processed' );
>+ok( Scalar::Util::looks_like_number( $init_results->{total} ), 'Total records fetched' );
> isnt( $init_results->{letter_message_id}, undef, 'Report has been enqueued' );
> 
> my $record =
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35659: 160356 | 160357 | 160744 | 161813 | 161960 | 162004 | 162005 | 162006 | 162007 | 162008 | 162009 | 162010 | 162011 | 162527 | 162528 | 162692 | 162693 | 162694 | 163527 | 164586 | 164590 | 164602 | 164603 | 164604 | 164605 | 164606 | 164618 | 164619 | 164620 | 164621 | 164622 | 165199 | 165594 | 165595 | 165596 | 165597 | 165598 | 167106 | 167107 | 167171 | 167172 | 167173 | 167174 | 167175 | 167176 | 168982 | 168983 | 169941 | 171255 | 171258 | 171260 | 171264 | 171265 | 171267 | 171675 | 171676 | 171678 | 171679 | 172072 | 172073 | 172074 | 172075 | 172076 | 172077 | 172078 | 172079 | 172080 | 172081 | 172082 | 172083 | 172202 | 172203 | 172204 | 172205 | 172206 | 172207 | 172208 | 172209 | 172210 | 172211 | 172212 | 172213 | 173088 | 173089 | 173090 | 173091 | 173092 | 173093 | 173094 | 173095 | 173096 | 173097 | 173098 | 173099 | 173100 | 173101 | 173561 | 173599 | 173600 | 173601 | 173614 | 174790