Attachment 173606 Details for Bug 33484 – Bug 33484: Remove state settings from column level

[patch] Bug 33484: Remove state settings from column level

Bug-33484-Remove-state-settings-from-column-level.patch (text/plain), 1.92 KB, created by Jonathan Druart on 2024-10-29 09:45:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-10-29 09:45:13 UTC

Size: 1.92 KB

patch

obsolete

>From 2cc161ff3f7f37066e770bd6309f2e85278ee6ea Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 29 Oct 2024 10:14:02 +0100
>Subject: [PATCH] Bug 33484: Remove state settings from column level
>
>default_save_state and default_save_state_search were added at the
>column level, it's not needed.
>---
> C4/Utils/DataTables/TablesSettings.pm | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
>diff --git a/C4/Utils/DataTables/TablesSettings.pm b/C4/Utils/DataTables/TablesSettings.pm
>index af35c490396..0d2f87f39e0 100644
>--- a/C4/Utils/DataTables/TablesSettings.pm
>+++ b/C4/Utils/DataTables/TablesSettings.pm
>@@ -60,16 +60,10 @@ sub get_columns {
>     $columns = [
>         map {
>             {
>-                cannot_be_toggled         => exists $_->{cannot_be_toggled}  ? $_->{cannot_be_toggled}  : 0,
>-                cannot_be_modified        => exists $_->{cannot_be_modified} ? $_->{cannot_be_modified} : 0,
>-                is_hidden                 => exists $_->{is_hidden}          ? $_->{is_hidden}          : 0,
>-                default_save_state        => exists $_->{default_save_state} ? $_->{default_save_state} : 1,
>-                default_save_state_search => exists $_->{default_save_state_search}
>-                    && exists $_->{default_save_state}
>-                    && $_->{default_save_state}    # We need default_save_state
>-                ? $_->{default_save_state_search}
>-                : 0,
>-                columnname => $_->{columnname},
>+                cannot_be_toggled  => exists $_->{cannot_be_toggled}  ? $_->{cannot_be_toggled}  : 0,
>+                cannot_be_modified => exists $_->{cannot_be_modified} ? $_->{cannot_be_modified} : 0,
>+                is_hidden          => exists $_->{is_hidden}          ? $_->{is_hidden}          : 0,
>+                columnname         => $_->{columnname},
>             }
>         } @$columns
>     ];
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33484: 149444 | 149445 | 149447 | 149448 | 149449 | 149925 | 149926 | 149927 | 149928 | 149929 | 149930 | 149974 | 149975 | 149976 | 149977 | 149978 | 149979 | 173443 | 173444 | 173445 | 173446 | 173447 | 173448 | 173449 | 173450 | 173451 | 173452 | 173453 | 173454 | 173455 | 173456 | 173457 | 173458 | 173459 | 173460 | 173461 | 173462 | 173463 | 173464 | 173465 | 173466 | 173467 | 173468 | 173469 | 173470 | 173471 | 173472 | 173473 | 173474 | 173475 | 173476 | 173477 | 173478 | 173479 | 173480 | 173481 | 173482 | 173483 | 173484 | 173485 | 173486 | 173546 | 173606 | 173607 | 173985 | 174219