Bugzilla – Attachment 17362 Details for
Bug 8896
Delete serials no more missing from missinglist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8896 QA Followup for regex
Bug-8896-QA-Followup-for-regex.patch (text/plain), 1.47 KB, created by
Marcel de Rooy
on 2013-04-11 10:56:39 UTC
(
hide
)
Description:
Bug 8896 QA Followup for regex
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-04-11 10:56:39 UTC
Size:
1.47 KB
patch
obsolete
>From 940ba379c189e64d9b4e4a1b8b8f7583dec9cfca Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 11 Apr 2013 12:48:26 +0200 >Subject: [PATCH] Bug 8896 QA Followup for regex >Content-Type: text/plain; charset=utf-8 > >Making sure that the regex does not kill more than it should. >Here are my test results when removing serialseq 3 :) >3 => >3 => >3; => >1;3 => 1 >1; 3 => 1 >1; 3; => 1 >3;1 => 1 >3; 1 => 1 >3 ;1 => 1 >3 ; 1 => 1 >1;3;31 => 1;31 >1;3 ;31 => 1;31 >1;3; 31 => 1;31 >1; 3;31 => 1;31 >2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Serials.pm | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 784916c..35d4cd5 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -1140,7 +1140,11 @@ sub ModSerialStatus { > } > # in case serial has been previously marked as missing > if (grep /$status/, (1,2,3,7)) { >- $missinglist =~ s/[,;]?\s?$serialseq//g; >+ #delete e.g. 3 not 31: therefore check on punct. and \D >+ $missinglist =~ s/(^|\s|[,;])$serialseq(?=\D|$)//g; >+ #cleanup the ; mess :) >+ $missinglist =~ s/[,;\s]+/;/g; >+ $missinglist =~ s/^[,;\s]+|[,;\s]+$//; > } > # warn "missinglist : $missinglist serialseq :$serialseq, ".index("$missinglist","$serialseq"); > $missinglist .= "; $serialseq" >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8896
:
12754
|
14657
|
15436
|
17275
|
17362
|
17363
|
17364
|
17365
|
17366
|
17577
|
17927
|
17928