Bugzilla – Attachment 173648 Details for
Bug 38287
Saving default checkout, hold and return policy with empty bookings values causes error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38287: Add missing rule_value access
Bug-38287-Add-missing-rulevalue-access.patch (text/plain), 1.94 KB, created by
Pedro Amorim
on 2024-10-29 14:02:22 UTC
(
hide
)
Description:
Bug 38287: Add missing rule_value access
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-10-29 14:02:22 UTC
Size:
1.94 KB
patch
obsolete
>From 89be501b1cc863df25f795e15ae30b9b65b56ea2 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 29 Oct 2024 14:01:05 +0000 >Subject: [PATCH] Bug 38287: Add missing rule_value access > >Test plan: >1) Access circuation rules: >http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl >2) Scroll down to "Default checkout, hold and return policy". Enter nothing. Hit 'Save'. >3) Notice on page reload there is a Koha:: object on the bookings inputs >4) Save again -> ERROR >5) Apply patch. Repeat. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 0b143b0cea..14bba56ee4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -764,10 +764,10 @@ > </select> > </td> > <td> >- <input type="text" name="bookings_lead_period" class="bookinglead" size="3" value="[% bookings_lead_period | html %]"> >+ <input type="text" name="bookings_lead_period" class="bookinglead" size="3" value="[% bookings_lead_period.rule_value | html %]"> > </td> > <td> >- <input type="text" name="bookings_trail_period" class="bookingtrail" size="3" value="[% bookings_trail_period | html %]"> >+ <input type="text" name="bookings_trail_period" class="bookingtrail" size="3" value="[% bookings_trail_period.rule_value | html %]"> > </td> > <td> > <select name="returnbranch"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38287
:
173648
|
173649
|
173681
|
173682
|
173743
|
173744