Bugzilla – Attachment 173713 Details for
Bug 38297
The "New vendor" button needs a permissions guard
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38297: Add a permissions check to the New vendor button
Bug-38297-Add-a-permissions-check-to-the-New-vendo.patch (text/plain), 2.10 KB, created by
Owen Leonard
on 2024-10-30 12:05:44 UTC
(
hide
)
Description:
Bug 38297: Add a permissions check to the New vendor button
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-10-30 12:05:44 UTC
Size:
2.10 KB
patch
obsolete
>From 5ff54e7b3ed1103d0ae0518ad585cc4ec8e212f3 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 30 Oct 2024 11:46:05 +0000 >Subject: [PATCH] Bug 38297: Add a permissions check to the New vendor button > >Test plan: >1) Choose a staff patron and make sure they have permissions to log > into the staff interface >2) Ensure that the patron does not have the vendors_manage permission > but give them one other acquisitions permission so that they can see > the link on the homepage (e.g. budget_manage) >3) In an incognito browser, log in with that patron and go to the > acquisitions homepage >4) The New vendor button will be visible >5) Click on it and fill in the required fields. Submit the form and it > will error for lack of permissions >6) Apply patch >7) Return to the acquisitions page and the New vendor button should no > longer be visible >8) Back in your main browser, give the patron the vendors_manage > permission and then refresh the incognito window - the button should > be visible > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >index d6b6ff9f98..cba26b9258 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >@@ -29,7 +29,7 @@ > [% IF CAN_user_acquisition_order_receive && basketcount && active %] > <div class="btn-group"><a class="btn btn-default" id="receive" href="/cgi-bin/koha/acqui/parcels.pl?booksellerid=[% booksellerid | html %]"><i class="fa fa-inbox"></i> Receive shipments</a></div> > [% END %] >- [% ELSE %] >+ [% ELSIF ( CAN_user_acquisition_vendors_manage ) %] > <div class="btn-group"><a class="btn btn-default" href="/cgi-bin/koha/acqui/supplier.pl?op=enter"><i class="fa fa-plus"></i> New vendor</a></div> > [% END %] > </div> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38297
:
173710
|
173711
|
173713
|
173763