Attachment 173728 Details for Bug 37872 – Bug 37872: Add guards for enable_plugins

[patch] Bug 37872: Add guards for enable_plugins

Bug-37872-Add-guards-for-enableplugins.patch (text/plain), 1.60 KB, created by David Nind on 2024-10-30 16:59:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-30 16:59:37 UTC

Size: 1.60 KB

patch

obsolete

>From cfc133bf8aab7383d4183bb31d817159aa353749 Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Mon, 9 Sep 2024 16:51:10 +0000
>Subject: [PATCH] Bug 37872: Add guards for enable_plugins
>
>There are ILL-backends that are not implemented as
>Koha plugins and does not require plugins to be enabled.
>
>The 'new' method in Koha::Plugins returns undefined if
>plugins are disabled.  Therefore, calls to this method
>must be guarded by a check that plugins actually are enabled.
>
>Testplan for koha-testing-docker:
>
>- Edit /etc/koha/sites/kohadev/koha-conf.xml and disable plugins by
>  setting <enable_plugins>0</enable_plugins>
>- sudo koha-mysql kohadev -e "UPDATE systempreferences SET value='1' WHERE variable='ILLModule';"
>- Run restart_all.
>- In staff interface, go to About koha -> System information. The page
>  should load normally (as opposed to returning 500 internal server
>  error).
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/ILL/Request/Config.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/ILL/Request/Config.pm b/Koha/ILL/Request/Config.pm
>index 111317804c..70f73f0ff5 100644
>--- a/Koha/ILL/Request/Config.pm
>+++ b/Koha/ILL/Request/Config.pm
>@@ -115,6 +115,7 @@ Returns a list of names for all the installed ILL backend plugins.
> sub get_backend_plugin_names {
>     my ( $self ) = @_;
> 
>+    return () unless C4::Context->config("enable_plugins");
>     my @backend_plugins = Koha::Plugins->new()->GetPlugins(
>         {
>             method => 'ill_backend',
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37872: 171227 | 171237 | 173617 | 173618 | 173619 | 173727 | 173728 | 173729 | 173771 | 173772 | 173773