Attachment 173734 Details for Bug 38279 – Bug 38279: Remove unused C4::ImportBatch::EmbedItemsInImportBiblio

[patch] Bug 38279: Remove unused C4::ImportBatch::EmbedItemsInImportBiblio

Bug-38279-Remove-unused-C4ImportBatchEmbedItemsInI.patch (text/plain), 1.45 KB, created by David Nind on 2024-10-30 18:22:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-30 18:22:18 UTC

Size: 1.45 KB

patch

obsolete

>From 61ecadd4ea69226714e66c1812151e565459df7b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 28 Oct 2024 14:26:14 +0100
>Subject: [PATCH] Bug 38279: Remove unused
> C4::ImportBatch::EmbedItemsInImportBiblio
>
>Last call removed from bug 30779 (I think)
>
>Test plan:
>  % git grep EmbedItemsInImportBiblio
>should not return anything
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/ImportBatch.pm | 18 ------------------
> 1 file changed, 18 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index 0cfd132edf..5aebaafacf 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -192,24 +192,6 @@ sub GetImportRecordMarc {
>     return $marc, $encoding;
> }
> 
>-sub EmbedItemsInImportBiblio {
>-    my ( $record, $import_record_id ) = @_;
>-    my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber" );
>-    my $dbh = C4::Context->dbh;
>-    my $import_items = $dbh->selectall_arrayref(q|
>-        SELECT import_items.marcxml
>-        FROM import_items
>-        WHERE import_record_id = ?
>-    |, { Slice => {} }, $import_record_id );
>-    my @item_fields;
>-    for my $import_item ( @$import_items ) {
>-        my $item_marc = MARC::Record::new_from_xml($import_item->{marcxml}, 'UTF-8');
>-        push @item_fields, $item_marc->field($itemtag);
>-    }
>-    $record->append_fields(@item_fields);
>-    return $record;
>-}
>-
> =head2 AddImportBatch
> 
>   my $batch_id = AddImportBatch($params_hash);
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38279: 173537 | 173734 | 173830