Attachment 173735 Details for Bug 38284 – Bug 38284: Add tests

[patch] Bug 38284: Add tests

Bug-38284-Add-tests.patch (text/plain), 1.49 KB, created by David Nind on 2024-10-30 18:31:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-30 18:31:39 UTC

Size: 1.49 KB

patch

obsolete

>From c61e6b301a2aeb7570c31521cf8f810b2ddee1c6 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 29 Oct 2024 09:23:31 +0000
>Subject: [PATCH] Bug 38284: Add tests
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/SIP/Message.t | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t
>index 325d9361d4..faf428d08f 100755
>--- a/t/db_dependent/SIP/Message.t
>+++ b/t/db_dependent/SIP/Message.t
>@@ -428,7 +428,7 @@ subtest "Test patron_status_string" => sub {
> 
> subtest 'Lastseen response patron status' => sub {
> 
>-    plan tests => 6;
>+    plan tests => 7;
> 
>     my $schema = Koha::Database->new->schema;
>     $schema->storage->txn_begin;
>@@ -488,6 +488,21 @@ subtest 'Lastseen response patron status' => sub {
>         output_pref( { str => $seen_patron->lastseen(), dateonly => 1 } ),
>         output_pref( { dt  => dt_from_string(), dateonly => 1 } ), 'Last seen updated if tracking patrons'
>     );
>+
>+    my $invalid_cardnumber_siprequest =
>+        PATRON_STATUS_REQ
>+    . 'engYYYYMMDDZZZZHHMMSS'
>+    . FID_INST_ID
>+    . $branchcode . '|'
>+    . FID_PATRON_ID
>+    . 'thiscardnumberdoesnotexist' . '|'
>+    . FID_PATRON_PWD
>+    . PATRON_PW . '|';
>+    my $invalid_msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 );
>+    $msg->handle_patron_status($server);
>+
>+    isnt( $response, undef, 'At least we got a response.' );
>+
>     $schema->storage->txn_rollback;
> 
> };
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38284: 173603 | 173604 | 173735 | 173736 | 173922 | 173923 | 174284 | 174285