Attachment 173736 Details for Bug 38284 – Bug 38284: Add patron check for TrackLastPatronActivityTriggers

[patch] Bug 38284: Add patron check for TrackLastPatronActivityTriggers

Bug-38284-Add-patron-check-for-TrackLastPatronActi.patch (text/plain), 1.29 KB, created by David Nind on 2024-10-30 18:31:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-30 18:31:42 UTC

Size: 1.29 KB

patch

obsolete

>From 4cb7013226ccf89833ea2fd9ccb053756f2d0c77 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 29 Oct 2024 09:24:36 +0000
>Subject: [PATCH] Bug 38284: Add patron check for
> TrackLastPatronActivityTriggers
>
>If an invalid or empty cardnumber is supplied to patron status request SIP message, SIP dies silently and no 'READ:' exists on the response.
>
>Test plan:
>1) Apply tests plan, run tests:
>$ prove t/db_dependent/SIP/Message.t
>2) Verify tests fail. Apply 2nd patch. Run tests again. Verify they pass.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/SIP/Sip/MsgType.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index 6ad48672fd..7978f9593d 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -504,7 +504,7 @@ sub handle_patron_status {
> 
>     $ils->check_inst_id( $fields->{ (FID_INST_ID) }, "handle_patron_status" );
>     $patron = $ils->find_patron( $fields->{ (FID_PATRON_ID) } );
>-    if ( C4::Context->preference('TrackLastPatronActivityTriggers') ) {
>+    if ( C4::Context->preference('TrackLastPatronActivityTriggers') && $patron ) {
>         my $koha_patron = Koha::Patrons->find($patron->{borrowernumber});
>         $koha_patron->update_lastseen('connection');
>     }
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38284: 173603 | 173604 | 173735 | 173736 | 173922 | 173923 | 174284 | 174285