Bugzilla – Attachment 173740 Details for
Bug 37238
Add table settings to itemsearch results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37238: (follow-up) Deal with table state, remove sharable link
Bug-37238-follow-up-Deal-with-table-state-remove-s.patch (text/plain), 5.29 KB, created by
Lucas Gass (lukeg)
on 2024-10-30 23:08:23 UTC
(
hide
)
Description:
Bug 37238: (follow-up) Deal with table state, remove sharable link
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-10-30 23:08:23 UTC
Size:
5.29 KB
patch
obsolete
>From 1c2d89df87d381d8babd5dac269b6baf2cb2df13 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 30 Oct 2024 23:07:50 +0000 >Subject: [PATCH] Bug 37238: (follow-up) Deal with table state, remove sharable > link > >--- > .../prog/en/includes/columns_settings.inc | 2 +- > .../prog/en/modules/admin/columns_settings.tt | 42 ++++++++++--------- > 2 files changed, 23 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index 46411008b07..b44b1039bb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -215,7 +215,7 @@ function KohaTable(id_selector, dt_parameters, table_settings, add_filters) { > } > ); > >- if ( table_settings ) { >+ if ( table_settings && ( table_settings.hasOwnProperty('default_save_state') && table_settings['default_save_state'] !== 0 ) ) { > dt_parameters["buttons"].push( > { > autoClose: true, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index 8bf0b32d448..b71c75440df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -149,26 +149,28 @@ > </p> > [% END %] > >- <p> >- [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %] >- <label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label> >- [%- IF table_settings.default_save_state -%] >- <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" /> >- [%- ELSE -%] >- <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" /> >- [%- END -%] >- </p> >- >- <p> >- [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %] >- <label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label> >- [%- IF table_settings.default_save_state_search -%] >- <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" /> >- [%- ELSE -%] >- <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" /> >- [%- END -%] >- </p> >- >+ [% IF table_settings.default_save_state %] >+ <p> >+ [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %] >+ <label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label> >+ [%- IF table_settings.default_save_state -%] >+ <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" /> >+ [%- ELSE -%] >+ <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" /> >+ [%- END -%] >+ </p> >+ [% END %] >+ [% IF table_settings.default_save_state_search %] >+ <p> >+ [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %] >+ <label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label> >+ [%- IF table_settings.default_save_state_search -%] >+ <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" /> >+ [%- ELSE -%] >+ <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" /> >+ [%- END -%] >+ </p> >+ [% END %] > </div> > [% END %] > <fieldset class="action"> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37238
:
168409
|
168411
|
168483
|
170785
|
171037
|
173414
|
173415
|
173416
|
173740
|
173765
|
173766
|
173768
|
173785
|
173786
|
173787