Bugzilla – Attachment 173783 Details for
Bug 28965
Add public routes for lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28965: Unit tests
Bug-28965-Unit-tests.patch (text/plain), 5.91 KB, created by
Martin Renvoize (ashimema)
on 2024-10-31 11:49:29 UTC
(
hide
)
Description:
Bug 28965: Unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-31 11:49:29 UTC
Size:
5.91 KB
patch
obsolete
>From 76ee704b4790dcaa589428cf652c7ae11097b8ba Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 29 Oct 2024 16:06:26 -0300 >Subject: [PATCH] Bug 28965: Unit tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/api/v1/public/lists.t | 123 +++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) > create mode 100755 t/db_dependent/api/v1/public/lists.t > >diff --git a/t/db_dependent/api/v1/public/lists.t b/t/db_dependent/api/v1/public/lists.t >new file mode 100755 >index 00000000000..5a3653fd3c8 >--- /dev/null >+++ b/t/db_dependent/api/v1/public/lists.t >@@ -0,0 +1,123 @@ >+#!/usr/bin/env perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 1; >+use Test::Mojo; >+ >+use JSON qw(encode_json); >+ >+use t::lib::TestBuilder; >+use t::lib::Mocks; >+ >+use Koha::Virtualshelves; >+use Koha::Database; >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+my $t = Test::Mojo->new('Koha::REST::V1'); >+t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 ); >+ >+subtest 'list_public() tests' => sub { >+ >+ plan tests => 30; >+ >+ $schema->storage->txn_begin; >+ >+ my $password = 'thePassword123'; >+ >+ my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } ); >+ my $patron_2 = $builder->build_object( { class => 'Koha::Patrons' } ); >+ >+ $patron_1->set_password( { password => $password, skip_validation => 1 } ); >+ my $patron_1_userid = $patron_1->userid; >+ >+ $patron_2->set_password( { password => $password, skip_validation => 1 } ); >+ my $patron_2_userid = $patron_2->userid; >+ >+ my $list_1 = >+ $builder->build_object( { class => 'Koha::Virtualshelves', value => { owner => $patron_1->id, public => 1 } } ); >+ my $list_2 = >+ $builder->build_object( { class => 'Koha::Virtualshelves', value => { owner => $patron_1->id, public => 0 } } ); >+ my $list_3 = >+ $builder->build_object( { class => 'Koha::Virtualshelves', value => { owner => $patron_2->id, public => 1 } } ); >+ my $list_4 = >+ $builder->build_object( { class => 'Koha::Virtualshelves', value => { owner => $patron_2->id, public => 0 } } ); >+ >+ my $q = encode_json( >+ { >+ list_id => { >+ -in => [ >+ $list_1->id, >+ $list_2->id, >+ $list_3->id, >+ $list_4->id, >+ ] >+ } >+ } >+ ); >+ >+ # anonymous >+ $t->get_ok("/api/v1/public/lists?q=$q")->status_is( 200, "Anonymous users can only fetch public lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ) ] ); >+ >+ $t->get_ok("/api/v1/public/lists?q=$q&only_public=1") >+ ->status_is( 200, "Anonymous users can only fetch public lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ) ] ); >+ >+ $t->get_ok("/api/v1/public/lists?q=$q&only_mine=1") >+ ->status_is( 400, "Passing only_mine on an anonymous session generates a 400 code" ) >+ ->json_is( '/error_code' => q{only_mine_forbidden} ); >+ >+ $t->get_ok("//$patron_1_userid:$password@/api/v1/public/lists?q=$q&only_mine=1") >+ ->status_is( 200, "Passing only_mine with a logged in user makes it return only their lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ), $list_2->to_api( { public => 1 } ) ] ); >+ >+ $t->get_ok("//$patron_2_userid:$password@/api/v1/public/lists?q=$q&only_mine=1") >+ ->status_is( 200, "Passing only_mine with a logged in user makes it return only their lists" ) >+ ->json_is( [ $list_3->to_api( { public => 1 } ), $list_4->to_api( { public => 1 } ) ] ); >+ >+ # only public >+ $t->get_ok("//$patron_1_userid:$password@/api/v1/public/lists?q=$q&only_public=1") >+ ->status_is( 200, "Passing only_public with a logged in user makes it return only public lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ) ] ); >+ >+ $t->get_ok("//$patron_2_userid:$password@/api/v1/public/lists?q=$q&only_public=1") >+ ->status_is( 200, "Passing only_public with a logged in user makes it return only public lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ) ] ); >+ >+ $t->get_ok("//$patron_1_userid:$password@/api/v1/public/lists?q=$q") >+ ->status_is( 200, "Not filtering with only_mine or only_public makes it return all accessible lists" ) >+ ->json_is( >+ [ $list_1->to_api( { public => 1 } ), $list_2->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ) ] >+ ); >+ >+ $t->get_ok("//$patron_2_userid:$password@/api/v1/public/lists?q=$q") >+ ->status_is( 200, "Not filtering with only_mine or only_public makes it return all accessible lists" ) >+ ->json_is( >+ [ $list_1->to_api( { public => 1 } ), $list_3->to_api( { public => 1 } ), $list_4->to_api( { public => 1 } ) ] >+ ); >+ >+ # conflicting params >+ $t->get_ok("//$patron_1_userid:$password@/api/v1/public/lists?q=$q&only_public=1&only_mine=1") >+ ->status_is( 200, "Passing only_public with a logged in user makes it return only public lists" ) >+ ->json_is( [ $list_1->to_api( { public => 1 } ) ] ); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28965
:
124635
|
124636
|
165976
|
165977
|
173624
|
173625
|
173626
|
173627
|
173687
|
173688
|
173689
|
173690
|
173780
|
173781
|
173782
| 173783