Bugzilla – Attachment 173836 Details for
Bug 38257
Several functionalities broken in cart pop up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38257: Do not use js_includes.inc in two different files
Bug-38257-Do-not-use-jsincludesinc-in-two-differen.patch (text/plain), 1.45 KB, created by
Aleisha Amohia
on 2024-10-31 20:08:08 UTC
(
hide
)
Description:
Bug 38257: Do not use js_includes.inc in two different files
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2024-10-31 20:08:08 UTC
Size:
1.45 KB
patch
obsolete
>From 82d1f76015f62d97c2d61c5f121ee6a26f410dee Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Mon, 28 Oct 2024 12:03:26 +0200 >Subject: [PATCH] Bug 38257: Do not use js_includes.inc in two different files > >Downloading cart didn't work because js_includes.inc file >was included both in basket.tt and intranet-bottom.inc. >This patch removes related codeline from basket.tt. > >To test: >1. Search for items and add one or more search results to your cart. >2. Open cart. >3. Attempt to download items from your cart. >=> Either nothing happens. >4. Apply this patch, restart services if needed. >5. Again attempt to download. >=> Download menu should now work as expected. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >index ac25ebad179..4e935c8ea27 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >@@ -356,7 +356,6 @@ > </div> [% # /.main.container-fluid %] > > [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] >- [% INCLUDE js_includes.inc %] > [% INCLUDE 'datatables.inc' %] > [% Asset.js("js/cart.js") | $raw %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38257
:
173263
|
173488
|
173489
|
173683
|
173835
| 173836