Bugzilla – Attachment 173850 Details for
Bug 21731
t::lib::QA::TemplateFilters missing built-in TT filter "xml" causes false warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21731: Try to fix filter detection in QA script for xml filter
Bug-21731-Try-to-fix-filter-detection-in-QA-script.patch (text/plain), 1.15 KB, created by
David Cook
on 2024-11-01 01:50:21 UTC
(
hide
)
Description:
Bug 21731: Try to fix filter detection in QA script for xml filter
Filename:
MIME Type:
Creator:
David Cook
Created:
2024-11-01 01:50:21 UTC
Size:
1.15 KB
patch
obsolete
>From 9b48cabcdcd7f4c16f4dba9878427e6c209a474b Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 1 Nov 2024 01:44:31 +0000 >Subject: [PATCH] Bug 21731: Try to fix filter detection in QA script for xml > filter > >This change adds support for the "xml" filter to the QA script. > >Test plan: >1. Change a "html" filter in opac-main.tt to use "xml" instead, > and temporarily commit your change >2. Run "qa" script >3. Notice it fails > >4. Apply the BZ patch > >5. Run "qa" script >6. Note that it passes now >7. Sign off the BZ patch and only upload it (and not your temporary > commit which you can delete after) >--- > t/lib/QA/TemplateFilters.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/lib/QA/TemplateFilters.pm b/t/lib/QA/TemplateFilters.pm >index 113b1f9163..d63a73ab19 100644 >--- a/t/lib/QA/TemplateFilters.pm >+++ b/t/lib/QA/TemplateFilters.pm >@@ -158,6 +158,9 @@ sub process_tt_block { > # Already has url or uri filter > or $tt_block =~ m{\|\s?ur(l|i)} > >+ # Already has url or uri filter >+ or $tt_block =~ m{\|\s?xml} >+ > # Already has trim filter > or $tt_block =~ m{\|\s?trim} > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21731
: 173850