Attachment 17386 Details for Bug 6506 – Bug 6506: Followup add warning in the system information tab.

[patch] Bug 6506: Followup add warning in the system information tab.

Bug-6506-Followup-add-warning-in-the-system-inform.patch (text/plain), 3.30 KB, created by Kyle M Hall (khall) on 2013-04-12 13:17:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-04-12 13:17:06 UTC

Size: 3.30 KB

patch

obsolete

>From 51f9d1f08ea1b71ae32f0a5a2d4af560560e2737 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 9 Apr 2013 12:08:56 +0200
>Subject: [PATCH] Bug 6506: Followup add warning in the system information tab.
>
>Add a warning in the system information tab of the about page.
>
>Test plan:
>Set OPACPrivacy = 1 and AnonymousPatron = 0 and go on the about page,
>tab 'system information'. Check that the warning appears.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> about.pl                                         |    5 +++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt |    5 ++++-
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
>diff --git a/about.pl b/about.pl
>index 96a8b5a..b9508c6 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -68,6 +68,10 @@ my $warnPrefBiblioAddsAuthorities = ( $prefAutoCreateAuthorities && ( !$prefBibl
> my $prefEasyAnalyticalRecords  = C4::Context->preference('EasyAnalyticalRecords');
> my $prefUseControlNumber  = C4::Context->preference('UseControlNumber');
> my $warnPrefEasyAnalyticalRecords  = ( $prefEasyAnalyticalRecords  && $prefUseControlNumber );
>+my $warnPrefAnonymousPatron = (
>+    C4::Context->preference('OPACPrivacy')
>+        and not C4::Context->preference('AnonymousPatron')
>+);
> 
> my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();
> 
>@@ -86,6 +90,7 @@ $template->param(
>     prefAutoCreateAuthorities => $prefAutoCreateAuthorities,
>     warnPrefBiblioAddsAuthorities => $warnPrefBiblioAddsAuthorities,
>     warnPrefEasyAnalyticalRecords  => $warnPrefEasyAnalyticalRecords,
>+    warnPrefAnonymousPatron => $warnPrefAnonymousPatron,
>     errZebraConnection => $errZebraConnection,
>     warnIsRootUser => $warnIsRootUser,
> );
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 8b4977c..3677fc7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -104,7 +104,7 @@
>             <p>Please log in instead with a regular staff account. To create a staff account, create a library, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar.</p>
>         [% END %]
>             <h2>Warnings regarding the system configuration</h2>
>-        [% IF ( (warnPrefBiblioAddsAuthorities) || warnPrefEasyAnalyticalRecords ) %]
>+        [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron %]
>         <table>
>             <caption>Preferences</caption>
>             [% IF (warnPrefBiblioAddsAuthorities) %]
>@@ -113,6 +113,9 @@
>             [% IF (warnPrefEasyAnalyticalRecords) %]
>             <tr><th scope="row"><b>Warning</b> </th><td>System preference 'EasyAnalyticalRecords' set, but UseControlNumber preference is set to 'Use'. Set it to 'Don't use' or else the 'Show analytics' links in the staff client and the OPAC will be broken.</td></tr>
>             [% END %]
>+            [% IF warnPrefAnonymousPatron %]
>+                <tr><th scope="row"><b>Warning</b> </th><td>System preference 'OPACPrivacy' set, but AnonymousPatron preference is set to '0'. Set it to a valid borrower number if you want that this feature works correctly.</td></tr>
>+            [% END %]
>         </table>
>         [% ELSE %]
>             <p>No warnings</p>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6506: 16955 | 17113 | 17305 | 17317 | 17385 | 17386 | 17387 | 17753 | 17754 | 17755