Bugzilla – Attachment 173890 Details for
Bug 38329
Remove orphan confirm_deletion() in supplier.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38329: Remove orphan confirm_deletion() in supplier.tt
Bug-38329-Remove-orphan-confirmdeletion-in-supplie.patch (text/plain), 1.73 KB, created by
Phil Ringnalda
on 2024-11-01 19:53:32 UTC
(
hide
)
Description:
Bug 38329: Remove orphan confirm_deletion() in supplier.tt
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2024-11-01 19:53:32 UTC
Size:
1.73 KB
patch
obsolete
>From b1208468f9ad62019d4c34023410dbc2894503a9 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Fri, 1 Nov 2024 12:33:32 -0700 >Subject: [PATCH] Bug 38329: Remove orphan confirm_deletion() in supplier.tt > >The JavaScript function confirm_deletion() in supplier.tt has either been an >unused orphan since bug 28082 two years ago, or since the switch from YUI to >Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was >called, it would fail by trying to GET with op="delete" rather than POST with >op="cud-delete". > >Test plan: > 1. Acquisitions - New vendor, enter a name and Save > 2. Click the name of your new vendor, so your URL is at supplier.pl > 3. Click Delete vendor to verify that deleting still works without this > unused code which would fail > >Sponsored-by: Chetco Community Public Library >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 36ad96f4ac..1a2450ee93 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -535,12 +535,6 @@ > [% Asset.js("js/acq.js") | $raw %] > [% INCLUDE 'datatables.inc' %] > <script> >- function confirm_deletion() { >- if (confirm(_("Confirm deletion of this vendor ?"))) { >- window.location="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | html %]&op=delete"; >- } >- } >- > function add_contact() { > var new_contact = $('#contact-template').clone(); > var timestamp = new Date().getTime(); >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38329
:
173890
|
173948
|
174044