Attachment 173893 Details for Bug 35906 – Bug 35906: (QA follow-up) Remove use of IF NOT EXISTS

[patch] Bug 35906: (QA follow-up) Remove use of IF NOT EXISTS

Bug-35906-QA-follow-up-Remove-use-of-IF-NOT-EXISTS.patch (text/plain), 1.29 KB, created by Tomás Cohen Arazi (tcohen) on 2024-11-01 21:06:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-11-01 21:06:33 UTC

Size: 1.29 KB

patch

obsolete

>From adfd70b1beb5c6ec83bed6b05edd55ba8c5ad3bb Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 1 Nov 2024 18:06:08 -0300
>Subject: [PATCH] Bug 35906: (QA follow-up) Remove use of IF NOT EXISTS
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/db_revs/240600045.pl | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/installer/data/mysql/db_revs/240600045.pl b/installer/data/mysql/db_revs/240600045.pl
>index fa3423fc77c..414d0301872 100755
>--- a/installer/data/mysql/db_revs/240600045.pl
>+++ b/installer/data/mysql/db_revs/240600045.pl
>@@ -8,13 +8,15 @@ return {
>         my ($args) = @_;
>         my ( $dbh, $out ) = @$args{qw(dbh out)};
> 
>-        $dbh->do(
>-            q{
>-            ALTER TABLE itemtypes ADD IF NOT EXISTS bookable INT(1) DEFAULT 0 AFTER automatic_checkin
>+        if ( !column_exists( 'itemtypes', 'bookable' ) ) {
>+            $dbh->do(
>+                q{
>+                ALTER TABLE itemtypes ADD COLUMN bookable INT(1) DEFAULT 0 AFTER automatic_checkin
>+            }
>+            );
>+
>+            say_success( $out, "Added column 'itemtypes.bookable'" );
>         }
>-        );
>-
>-        say_success( $out, "Added column 'itemtypes.bookable'" );
> 
>         $dbh->do(
>             q{
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 35906: 161397 | 161638 | 161744 | 161961 | 162242 | 162365 | 162465 | 162466 | 162467 | 162468 | 162469 | 162470 | 162472 | 163291 | 163292 | 163293 | 163294 | 163295 | 163547 | 163548 | 163549 | 163550 | 163551 | 164579 | 164580 | 164581 | 164582 | 164583 | 164584 | 164585 | 165437 | 166866 | 166867 | 166868 | 166869 | 166870 | 166871 | 168120 | 168121 | 168122 | 168160 | 168161 | 168162 | 168163 | 168164 | 170187 | 170188 | 170189 | 170190 | 170191 | 170582 | 170583 | 170584 | 170585 | 170586 | 172127 | 172128 | 172129 | 172130 | 172131 | 172132 | 172941 | 172945 | 172950 | 172951 | 172952 | 172953 | 172954 | 172955 | 172956 | 172957 | 172958 | 172959 | 172960 | 172961 | 173324 | 173325 | 173326 | 173327 | 173328 | 173329 | 173330 | 173331 | 173332 | 173333 | 173334 | 173335 | 173893