Bugzilla – Attachment 173915 Details for
Bug 38175
Improve bookings behavior with new status field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38175: (follow-up) Quiet warnings in tests
Bug-38175-follow-up-Quiet-warnings-in-tests.patch (text/plain), 1.30 KB, created by
Martin Renvoize (ashimema)
on 2024-11-04 13:12:31 UTC
(
hide
)
Description:
Bug 38175: (follow-up) Quiet warnings in tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-11-04 13:12:31 UTC
Size:
1.30 KB
patch
obsolete
>From 9cfb92c20637ba9b94f751f036c001b28eb191e2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 4 Nov 2024 13:08:06 +0000 >Subject: [PATCH] Bug 38175: (follow-up) Quiet warnings in tests > >We weren't passing the required data into the FKConstraint exception, >this patch passes biblio_id and value as required. >--- > Koha/Booking.pm | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/Koha/Booking.pm b/Koha/Booking.pm >index 2450465649b..8e9c45ad711 100644 >--- a/Koha/Booking.pm >+++ b/Koha/Booking.pm >@@ -115,8 +115,13 @@ sub store { > $self->biblio_id( $self->item->biblionumber ) > unless $self->biblio_id; > >- Koha::Exceptions::Object::FKConstraint->throw() >- unless ( $self->biblio_id == $self->item->biblionumber ); >+ Koha::Exceptions::Object::FKConstraint->throw( >+ broken_fk => 'item/biblio_id', >+ value => "item biblionumber: " >+ . $self->item->biblionumber >+ . " booking biblio_id: " >+ . $self->biblio_id >+ ) unless ( $self->biblio_id == $self->item->biblionumber ); > } > > Koha::Exceptions::Object::FKConstraint->throw( >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38175
:
172770
|
172771
|
172772
|
172773
|
172814
|
172815
|
172816
|
172817
|
172880
|
172881
|
172882
|
172883
|
172884
|
173172
|
173173
|
173174
|
173175
|
173176
|
173177
|
173178
|
173201
|
173202
|
173203
|
173346
| 173915