Bugzilla – Attachment 173935 Details for
Bug 28633
Add a preferred name field to patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28633: (QA follow-up) Tidy
Bug-28633-QA-follow-up-Tidy.patch (text/plain), 2.97 KB, created by
Martin Renvoize (ashimema)
on 2024-11-04 15:44:48 UTC
(
hide
)
Description:
Bug 28633: (QA follow-up) Tidy
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-11-04 15:44:48 UTC
Size:
2.97 KB
patch
obsolete
>From 103cd302c0400c7ac51d2a286b2d10cfc3069815 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 4 Nov 2024 15:27:02 +0000 >Subject: [PATCH] Bug 28633: (QA follow-up) Tidy > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Patron.t | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t >index 923906ef10d..8bbb12c2c1f 100755 >--- a/t/db_dependent/Koha/Patron.t >+++ b/t/db_dependent/Koha/Patron.t >@@ -2694,8 +2694,8 @@ subtest 'preferred_name' => sub { > > $schema->storage->txn_begin; > >- my $tmp_patron = $builder->build_object( { class => 'Koha::Patrons' } ); >- my $patron_data = $tmp_patron->unblessed; >+ my $tmp_patron = $builder->build_object( { class => 'Koha::Patrons' } ); >+ my $patron_data = $tmp_patron->unblessed; > $tmp_patron->delete; > delete $patron_data->{borrowernumber}; > delete $patron_data->{preferred_name}; >@@ -2707,7 +2707,7 @@ subtest 'preferred_name' => sub { > } > )->store; > >- is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on creation when not defined"); >+ is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on creation when not defined" ); > > $patron->delete; > >@@ -2720,12 +2720,12 @@ subtest 'preferred_name' => sub { > } > )->store; > >- is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on creation when empty string"); >+ is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on creation when empty string" ); > > $patron->delete; > > $patron_data->{preferred_name} = "Preferred"; >- $patron_data->{firstname} = "Not Preferred"; >+ $patron_data->{firstname} = "Not Preferred"; > > $patron = Koha::Patron->new( > >@@ -2734,15 +2734,15 @@ subtest 'preferred_name' => sub { > } > )->store; > >- is( $patron->preferred_name, "Preferred", "Preferred name set when passed on creation"); >+ is( $patron->preferred_name, "Preferred", "Preferred name set when passed on creation" ); > > $patron->preferred_name("")->store; >- is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on update when empty string"); >+ is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on update when empty string" ); > > $patron->preferred_name(undef)->store(); >- is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on update when undef"); >+ is( $patron->preferred_name, $patron->firstname, "Preferred name set to first name on update when undef" ); > > $patron->preferred_name("Preferred again")->store(); >- is( $patron->preferred_name, "Preferred again", "Preferred name set on update when passed"); >+ is( $patron->preferred_name, "Preferred again", "Preferred name set on update when passed" ); > > }; >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28633
:
123008
|
123009
|
123010
|
123658
|
125497
|
125498
|
125499
|
125500
|
126591
|
128968
|
128969
|
128970
|
130000
|
130001
|
130002
|
133445
|
133446
|
133447
|
133448
|
133449
|
133450
|
133451
|
133958
|
133959
|
133960
|
133961
|
133962
|
133963
|
133964
|
133965
|
166792
|
166793
|
166794
|
166813
|
166814
|
166815
|
166816
|
166817
|
167163
|
167164
|
173628
|
173629
|
173630
|
173631
|
173632
|
173633
|
173634
|
173664
|
173665
|
173666
|
173667
|
173668
|
173669
|
173670
|
173717
|
173718
|
173719
|
173813
|
173814
|
173815
|
173816
|
173826
|
173827
|
173828
|
173829
|
173930
|
173931
|
173932
|
173933
|
173934
| 173935 |
173936
|
174419
|
174420
|
174472
|
175177