Attachment 173989 Details for Bug 33348 – Bug 33348: Tests

[patch] Bug 33348: Tests

Bug-33348-Tests.patch (text/plain), 2.67 KB, created by Thomas Klausner on 2024-11-05 16:23:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Klausner

Created: 2024-11-05 16:23:30 UTC

Size: 2.67 KB

patch

obsolete

>From 6f352a8050343b3547ee691e9292d68644528c37 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Thu, 16 Nov 2023 21:38:35 +0000
>Subject: [PATCH] Bug 33348: Tests
>
>prove t/Koha/SearchEngine/Elasticsearch/Search.t
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>Signed-off-by: Thomas Klausner <domm@plix.at>
>---
> t/Koha/SearchEngine/Elasticsearch/Search.t | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/t/Koha/SearchEngine/Elasticsearch/Search.t b/t/Koha/SearchEngine/Elasticsearch/Search.t
>index cae1b2a96e..1ca6bd359e 100755
>--- a/t/Koha/SearchEngine/Elasticsearch/Search.t
>+++ b/t/Koha/SearchEngine/Elasticsearch/Search.t
>@@ -20,11 +20,13 @@ use Modern::Perl;
> use Test::More tests => 2;
> use Test::MockModule;
> use t::lib::Mocks;
>+use Encode       qw( encode );
>+use MIME::Base64 qw( encode_base64 );
> 
> use_ok('Koha::SearchEngine::Elasticsearch::Search');
> 
> subtest 'search_auth_compat' => sub {
>-    plan tests => 4;
>+    plan tests => 7;
> 
>     t::lib::Mocks::mock_preference( 'QueryRegexEscapeOptions', 'dont_escape' );
>     t::lib::Mocks::mock_preference( 'SearchEngine', 'Elasticsearch' );
>@@ -65,6 +67,10 @@ subtest 'search_auth_compat' => sub {
>             $marc_record->append_fields(
>                 MARC::Field->new( '001', 'Wrong001Number' ),
>             );
>+            $marc_record->append_fields(
>+                MARC::Field->new( '008', '100803n||a| nnaban          |a aaa    |d' ),
>+            );
>+            my $marc_data = encode_base64( encode( 'UTF-8', $marc_record->as_usmarc() ) );
>             return {
>                 hits => {
>                     hits => [
>@@ -72,7 +78,7 @@ subtest 'search_auth_compat' => sub {
>                             '_id'     => 8675309,
>                             '_source' => {
>                                 'local-number' => ['Wrong001Number'],
>-                                'marc_data'    => $marc_record,
>+                                'marc_data'    => $marc_data,
>                                 'marc_format'  => 'base64ISO2709',
>                             },
>                         }
>@@ -82,10 +88,17 @@ subtest 'search_auth_compat' => sub {
>         }
>     );
> 
>+    t::lib::Mocks::mock_preference( 'ShowHeadingUse', 1 );
>     my ( $results, undef ) = $search->search_auth_compat('faked');
> 
>     is( @$results[0]->{authid}, '8675309', 'We get the expected record _id and not the 001' );
> 
>+    is( @$results[0]->{main}, 1, 'Valid main heading with ShowHeadingUse' );
>+    is(
>+        @$results[0]->{subject},
>+        undef, 'Valid main heading with ShowHeadingUse'
>+    );
>+    is( @$results[0]->{series}, 1, 'Valid main heading with ShowHeadingUse' );
> };
> 
> 1;
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 33348: 148791 | 150440 | 150479 | 150481 | 150482 | 152570 | 152571 | 159066 | 171601 | 171602 | 171603 | 171686 | 171687 | 171688 | 171875 | 171876 | 173987 | 173988 | 173989