Attachment 174010 Details for Bug 34355 – Bug 34355: (QA follow-up) Tidy

[patch] Bug 34355: (QA follow-up) Tidy

Bug-34355-QA-follow-up-Tidy.patch (text/plain), 2.27 KB, created by Nick Clemens (kidclamp) on 2024-11-05 16:38:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-11-05 16:38:43 UTC

Size: 2.27 KB

patch

obsolete

>From 47e9fd15733dab8e0bea7a7742c3b7bf261f3a73 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 5 Nov 2024 16:32:50 +0000
>Subject: [PATCH] Bug 34355: (QA follow-up) Tidy
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/MarcOrder.pm | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/Koha/MarcOrder.pm b/Koha/MarcOrder.pm
>index 84ac5345443..d2cb6abeb24 100644
>--- a/Koha/MarcOrder.pm
>+++ b/Koha/MarcOrder.pm
>@@ -527,7 +527,6 @@ sub add_items_from_import_record {
>     }
> }
> 
>-
> =head3 match_file_to_account
> 
>     my $file_match = Koha::MarcOrder->match_file_to_account({
>@@ -960,7 +959,7 @@ sub create_items_and_generate_order_hash {
>     my $itemcreation    = 0;
>     my @itemnumbers;
> 
>-    if( C4::Context->preference('AcqCreateItem') ne 'cataloguing' ) {
>+    if ( C4::Context->preference('AcqCreateItem') ne 'cataloguing' ) {
>         for ( my $i = 0 ; $i < $loop_limit ; $i++ ) {
>             $itemcreation = 1;
>             my $item = Koha::Item->new(
>@@ -1106,11 +1105,14 @@ sub create_items_and_generate_order_hash {
>         $order->store;
> 
>         my $basket = Koha::Acquisition::Baskets->find($basket_id);
>-        if ( C4::Context->preference('AcqCreateItem') ne 'cataloguing' && $basket->effective_create_items eq 'ordering' && !$basket->is_standing ) {
>-            my $tags         = $fields->{tags} || [];
>-            my $subfields    = $fields->{subfields} || [];
>+        if (   C4::Context->preference('AcqCreateItem') ne 'cataloguing'
>+            && $basket->effective_create_items eq 'ordering'
>+            && !$basket->is_standing )
>+        {
>+            my $tags         = $fields->{tags}         || [];
>+            my $subfields    = $fields->{subfields}    || [];
>             my $field_values = $fields->{field_values} || [];
>-            my $serials      = $fields->{serials} || [];
>+            my $serials      = $fields->{serials}      || [];
>             my $xml          = TransformHtmlToXml( $tags, $subfields, $field_values );
>             my $record       = MARC::Record::new_from_xml( $xml, 'UTF-8' );
>             for ( my $qtyloop = 1 ; $qtyloop <= $fields->{c_quantity} ; $qtyloop++ ) {
>@@ -1248,5 +1250,4 @@ sub _create_item_fields_from_syspref {
>     return $item_fields;
> }
> 
>-
> 1;
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 34355: 154705 | 154706 | 154707 | 154708 | 154709 | 154710 | 157092 | 157093 | 157094 | 157095 | 157096 | 157097 | 157098 | 157099 | 157100 | 160858 | 160859 | 160860 | 160861 | 160862 | 160863 | 160864 | 160865 | 160866 | 160867 | 160868 | 160869 | 160870 | 160871 | 160872 | 160873 | 160874 | 160875 | 169896 | 169897 | 169898 | 169899 | 169900 | 169901 | 169902 | 169903 | 169904 | 170395 | 170401 | 170402 | 170403 | 170404 | 170405 | 170406 | 170407 | 170408 | 170409 | 173054 | 173055 | 173056 | 173057 | 173058 | 173059 | 173060 | 173061 | 173062 | 173063 | 173064 | 173065 | 173066 | 173709 | 173805 | 173806 | 173809 | 173824 | 173825 | 173993 | 173994 | 173995 | 173996 | 173997 | 173998 | 173999 | 174000 | 174001 | 174002 | 174003 | 174004 | 174005 | 174006 | 174007 | 174008 | 174009 | 174010 | 174362 | 174363 | 174364 | 174365 | 174366 | 174367 | 174368 | 174369 | 174370 | 174371 | 174372 | 174373 | 174374 | 174375 | 174376 | 174377 | 174378 | 174379 | 174380 | 174382 | 174383