Attachment 174040 Details for Bug 33766 – Bug 33766: (follow-up) Enable translation for strings

[patch] Bug 33766: (follow-up) Enable translation for strings

Bug-33766-follow-up-Enable-translation-for-strings.patch (text/plain), 1.95 KB, created by Lucas Gass (lukeg) on 2024-11-05 20:28:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-05 20:28:26 UTC

Size: 1.95 KB

patch

obsolete

>From 1c0dcbf4d715e39e140baee6b8a5a09021be9b43 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 31 Aug 2023 15:55:26 +0000
>Subject: [PATCH] Bug 33766: (follow-up) Enable translation for strings
>
>In my test the strings inside a SET directive were not picked up for
>translation. This patch adds the t() function around the new strings in
>order to allow them to be translated.
>
>To test, apply the patch and test the translation process for any
>language, in this example fr-FR:
>
>- Run 'perl translate update fr-FR'
>- Open misc/translator/po/fr-FR-messages.po
>- Look for the affected strings: "Username", "Cardnumber", and
>  "Cardnumber or username."
>- Update the po file with translations of the strings
>- Run 'perl translate install fr-FR'
>- View the OPAC in your translated language and test each setting of
>  OPACLoginLabelTextContent to confirm that the translated strings
>  appear.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
>index 3d5cdbaaa20..16dd2888a0e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
>@@ -179,11 +179,11 @@
> 
> [% BLOCK login_label %]
>     [%- SET preference_value = Koha.Preference('OPACLoginLabelTextContent') %]
>-    [%- SET label = "Cardnumber" %]
>+    [%- SET label = t("Cardnumber") %]
>     [%- IF preference_value == "username" %]
>-        [%- SET label = "Username" %]
>+        [%- SET label = t("Username") %]
>     [%- ELSIF preference_value == "cardnumberorusername" %]
>-        [%- SET label = "Cardnumber or username" %]
>+        [%- SET label = t("Cardnumber or username") %]
>     [%- END %]
>     <label for="[% for | html %]">[% label | html %]:</label>
> [% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33766: 151416 | 151427 | 154566 | 154567 | 154570 | 155017 | 155018 | 155019 | 155022 | 155023 | 155024 | 155025 | 155026 | 157854 | 157855 | 157856 | 157857 | 157858 | 159342 | 159546 | 159547 | 159548 | 159549 | 159550 | 168600 | 168601 | 168602 | 168603 | 168604 | 168605 | 173757 | 173758 | 173759 | 173760 | 173761 | 173762 | 173972 | 173973 | 173974 | 173975 | 173976 | 173977 | 174037 | 174038 | 174039 | 174040 | 174041 | 174042