Attachment 174045 Details for Bug 38325 – Bug 38325: Cannot delete invoice while viewing it

[patch] Bug 38325: Cannot delete invoice while viewing it

Bug-38325-Cannot-delete-invoice-while-viewing-it.patch (text/plain), 2.87 KB, created by Lucas Gass (lukeg) on 2024-11-05 20:52:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-05 20:52:05 UTC

Size: 2.87 KB

patch

obsolete

>From 8e6e99fa8ce90e2990d5138a4e03cf493dd22052 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Fri, 1 Nov 2024 09:13:50 -0700
>Subject: [PATCH] Bug 38325: Cannot delete invoice while viewing it
>
>The link to delete while viewing an individual invoice needs to be updated to
>use submit-form-link so it can POST with op='cud-delete'.
>
>Test plan:
> 1. Home - Acquisitions, click Search with an empty Vendor: input
> 2. Click Receive shipments, enter a number in the Vendor invoice input,
>    click Next
> 3. In the left sidebar, click Invoices, click Search without any parameters
> 4. In the row for your invoice, click the invoice number link
> 5. Next to the Save button, click the Delete link, click OK in the
>    confirmation alert
> 6. You'll see the page reload, and the URL change to include ?op=delete,
>    but your invoice remains undeleted.
> 7. Apply patch, reload the page
> 8. Click Delete, click OK in the confirmation alert
> 9. Click Search with no parameters, just to make sure the message about
>    "Sorry, but there are no results for your search" really truly means
>    that your invoice was deleted and now you don't have any invoices
>
>Sponsored-by: Chetco Community Public Library
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index edd10da42e2..baef5c261a4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -142,7 +142,7 @@
>                             <input type="hidden" name="invoiceid" value="[% invoiceid | html %]" />
>                             <input type="submit" class="btn btn-primary" value="Save" />
>                             [% IF CAN_user_acquisition_delete_invoices AND NOT orders_loop.size %]
>-                                <a href="invoice.pl?op=delete&invoiceid=[% invoiceid | uri %]" id="delete">Delete</a>
>+                                <a class="submit-form-link" href="#" data-action="invoice.pl" data-method="post" data-op="cud-delete" data-invoiceid="[% invoiceid | html %]" data-confirmation-msg="[% t('Are you sure you want to delete this invoice?') | html %]" id="delete">Delete</a>
>                             [% END %]
>                         </fieldset>
>                     [% END %]
>@@ -561,9 +561,6 @@
>         }
> 
>         $(document).ready(function() {
>-            $("#delete").click(function(){
>-                return confirmDelete(_("Are you sure you want to delete this invoice?"));
>-            });
>             $("#orderst").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "info": false,
>                 "paging": false,
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 38325: 173877 | 173886 | 174045