Attachment 174049 Details for Bug 38362 – Bug 38362: Fix printing lists on opac/opac-shelves.pl

[patch] Bug 38362: Fix printing lists on opac/opac-shelves.pl

Bug-38362-Fix-printing-lists-on-opacopac-shelvespl.patch (text/plain), 1.24 KB, created by Lucas Gass (lukeg) on 2024-11-05 22:15:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-05 22:15:00 UTC

Size: 1.24 KB

patch

obsolete

>From ac19c10f6c68b49a525204169d1235ebd409fdbe Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 5 Nov 2024 22:13:32 +0000
>Subject: [PATCH] Bug 38362: Fix printing lists on opac/opac-shelves.pl
>
>To test from the OPAC:
>1 - create a list with more than 10 items
>2 - print the list -> there is a pagination and that only 10 items
>  are printed
>3 - Apply patch
>4 - print the list again -> every items are being printed
>---
> opac/opac-shelves.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl
>index 728dad57d1b..c98f3fbb28f 100755
>--- a/opac/opac-shelves.pl
>+++ b/opac/opac-shelves.pl
>@@ -317,7 +317,9 @@ if ( $op eq 'view' ) {
>             $sortfield = 'title' if !$sortfield or !grep { $_ eq $sortfield } qw( title author copyrightdate itemcallnumber dateadded );
> 
>             my $rows;
>-            unless ( $query->param('print') or $query->param('rss') ) {
>+            if ( $query->param('print') or $query->param('rss') ) {
>+                $page="";
>+            } else {
>                 $rows = C4::Context->preference('OPACnumSearchResults') || 20;
>             }
>             my $order_by = $sortfield eq 'itemcallnumber' ? 'items.cn_sort' : $sortfield;
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 38362: 174049 | 174050