Attachment 17407 Details for Bug 9859 – [PATCH][SIGNED OFF] Bug 9859:fix nsb_clean side effect

[patch] [PATCH][SIGNED OFF] Bug 9859:fix nsb_clean side effect

attachment.cgi?id=16465 (text/plain), 1.17 KB, created by Mathieu Saby on 2013-04-12 17:09:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Saby

Created: 2013-04-12 17:09:26 UTC

Size: 1.17 KB

patch

obsolete

>From e9eee7b39a5c494f8c14e7500ac5cb8539473b62 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?St=C3=A9phane=20Delaune?= <stephane.delaune@biblibre.com>
>Date: Wed, 20 Mar 2013 10:54:46 +0100
>Subject: [PATCH][SIGNED OFF] Bug 9859:fix nsb_clean side effect
>
>Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
>This sub was causing 2 bugs :
>- tools/exports.pl --clean was removing Ã
>- authority search plugin used in cataloging was removing Ã in suggested authorities displayed dynamicly (using ajax)
>After applying the patch,
>- NSB/NSE are still removed by nsb_clean
>- tools/exports.pl --clean is no more removing Ã
>- authority search plugins is no more removing Ã
>
>---
> C4/Charset.pm |    7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Charset.pm b/C4/Charset.pm
>index f8ddd63..f5a2c9a 100644
>--- a/C4/Charset.pm
>+++ b/C4/Charset.pm
>@@ -409,11 +409,8 @@ sub nsb_clean {
>     # handles non sorting blocks
>     my ($string) = @_ ;
>     $_ = $string ;
>-    s/$NSB//g ;
>-    s/$NSE//g ;
>-    s/$NSB2//g ;
>-    s/$NSE2//g ;
>-    s/$C2//g ;
>+    s/($C2){0,1}($NSB|$NSB2)//g ;
>+    s/($C2){0,1}($NSE|$NSE2)//g ;
>     $string = $_ ;
> 
>     return($string) ;
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 9859: 16465 | 16469 | 17399 | 17407 | 32415 | 32416