Attachment 174074 Details for Bug 37171 – Bug 37171: Add serial note to serial claims screen

[patch] Bug 37171: Add serial note to serial claims screen

Bug-37171-Add-serial-note-to-serial-claims-screen.patch (text/plain), 3.53 KB, created by Martin Renvoize (ashimema) on 2024-11-06 11:35:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-11-06 11:35:19 UTC

Size: 3.53 KB

patch

obsolete

>From 833f8838f814a5765b119b907b6b88941672a8e4 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 6 Nov 2024 11:18:22 +0000
>Subject: [PATCH] Bug 37171: Add serial note to serial claims screen
>
>This patch adds the serial note field into the serials claims display
>table.
>
>Test plan:
>1) Add a Serial
>2) View the serial 'Serial collection'
>3) Use the 'Edit serials' option to add a note to an expected, late
>   serial issue.
>4) View the serial claims for the Vendor of that serial
>5) Note the new 'Serial notes' column in the display of claims
>6) Signoff
>---
> C4/Serials.pm                                             | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 4 ++++
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 4421bf35b0f..a14bea422d3 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -1893,7 +1893,7 @@ sub GetLateOrMissingIssues {
>             "SELECT
>                 serialid,      aqbooksellerid,        name,
>                 biblio.title,  biblioitems.issn,      planneddate,    serialseq,
>-                serial.status, serial.subscriptionid, claimdate, claims_count,
>+                serial.status, serial.subscriptionid, claimdate, serial.notes AS notes, claims_count,
>                 subscription.branchcode, serial.publisheddate
>             FROM      serial
>                 LEFT JOIN subscription  ON serial.subscriptionid=subscription.subscriptionid
>@@ -1911,7 +1911,7 @@ sub GetLateOrMissingIssues {
>             "SELECT
>             serialid,      aqbooksellerid,         name,
>             biblio.title,  planneddate,           serialseq,
>-                serial.status, serial.subscriptionid, claimdate, claims_count,
>+                serial.status, serial.subscriptionid, claimdate, serial.notes AS notes, claims_count,
>                 subscription.branchcode, serial.publisheddate
>             FROM serial
>                 LEFT JOIN subscription ON serial.subscriptionid=subscription.subscriptionid
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>index 56c96de3542..f0c571da9bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>@@ -140,6 +140,7 @@
>                                         <th>Publication date</th>
>                                         <th>Claims count</th>
>                                         <th>Claim date</th>
>+                                        <th>Serial notes</th>
>                                         [% FOR field IN additional_fields_for_subscription %]
>                                         <th>[% field.name | html %]</th>
>                                         [% END %]
>@@ -175,6 +176,9 @@
>                                             <td data-order="[% missingissue.claimdate | html %]">
>                                                 [% missingissue.claimdate | $KohaDates %]
>                                             </td>
>+                                            <td>
>+                                                [% missingissue.notes | html %]
>+                                            </td>
>                                             [% INCLUDE 'additional-fields-display.inc' available=additional_fields_for_subscription values=missingissue.additional_field_values value_only=1 is_table_cell=1 %]
>                                         </tr>
>                                     [% END # /FOREACH missingissue %]
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 37171: 174074