Attachment 174147 Details for Bug 38010 – Bug 38010: Allow searching by alias in the vendors table

[patch] Bug 38010: Allow searching by alias in the vendors table

Bug-38010-Allow-searching-by-alias-in-the-vendors-.patch (text/plain), 2.91 KB, created by Matt Blenkinsop on 2024-11-07 11:49:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-11-07 11:49:35 UTC

Size: 2.91 KB

patch

obsolete

>From 3e547246aa1ea897c27bd27975bff353a91a6f00 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Thu, 17 Oct 2024 17:47:59 +0100
>Subject: [PATCH] Bug 38010: Allow searching by alias in the vendors table
>
>---
> Koha/Schema/Result/Aqbookseller.pm               | 16 ++++++++++++++++
> .../js/vue/components/Vendors/VendorDetails.vue  | 11 +++++++----
> .../js/vue/components/Vendors/VendorList.vue     |  2 +-
> 3 files changed, 24 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Schema/Result/Aqbookseller.pm b/Koha/Schema/Result/Aqbookseller.pm
>index a4c1370b577..2d0834b9c1f 100644
>--- a/Koha/Schema/Result/Aqbookseller.pm
>+++ b/Koha/Schema/Result/Aqbookseller.pm
>@@ -535,6 +535,22 @@ __PACKAGE__->add_columns(
>     '+invoiceincgst' => { is_boolean => 1 },
> );
> 
>+
>+=head2 aliases
>+
>+Type: has_many
>+
>+Related object: L<Koha::Schema::Result::AqbooksellerAlias>
>+
>+=cut
>+
>+__PACKAGE__->has_many(
>+    "aliases",
>+    "Koha::Schema::Result::AqbooksellerAlias",
>+    { "foreign.vendor_id" => "self.id" },
>+    { cascade_copy        => 0, cascade_delete => 0 },
>+);
>+
> sub koha_object_class {
>     'Koha::Acquisition::Bookseller';
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorDetails.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorDetails.vue
>index 16180944b36..61290372172 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorDetails.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorDetails.vue
>@@ -60,11 +60,14 @@
>                     {{ vendor.accountnumber }}
>                 </span>
>             </li>
>-            <li v-if="vendor.aliases.count">
>+            <li v-if="vendor.aliases.length">
>                 <label>{{ $__("Aliases") }}:</label>
>-                <ul>
>-                    <li v-for="alias in vendor.aliases" :key="alias">
>-                        {{ alias }}
>+                <ul style="margin-left: 8rem">
>+                    <li
>+                        v-for="(alias, i) in vendor.aliases"
>+                        :key="alias.alias_id"
>+                    >
>+                        {{ $__("Alias") + " " + (i + 1) }}: {{ alias.alias }}
>                     </li>
>                 </ul>
>             </li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorList.vue
>index 5c3d31b8ebc..e28ba15b53e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorList.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorList.vue
>@@ -172,7 +172,7 @@ export default {
>             return [
>                 {
>                     title: __("Name"),
>-                    data: "me.name:me.id",
>+                    data: "me.name:aliases.alias:me.id",
>                     searchable: true,
>                     orderable: true,
>                     render(data, type, row, meta) {
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 38010: 174119 | 174120 | 174121 | 174122 | 174123 | 174124 | 174125 | 174126 | 174128 | 174129 | 174130 | 174131 | 174132 | 174133 | 174134 | 174135 | 174136 | 174137 | 174138 | 174139 | 174140 | 174141 | 174142 | 174143 | 174144 | 174145 | 174146 | 174147 | 174148 | 174151 | 174152 | 174153 | 174154 | 174155 | 174156 | 174157 | 174158 | 174159 | 174160 | 174161 | 174162 | 174163 | 174164 | 174165 | 174166 | 174167 | 174168 | 174169 | 174170 | 174171 | 174172 | 174173 | 174174 | 174175 | 174176 | 174177 | 174178 | 174179 | 174194 | 174196 | 174197 | 174198 | 174199 | 174200 | 174201 | 174202 | 174203 | 174204 | 174205 | 174206 | 174207 | 174208 | 174209 | 174210 | 174211 | 174212 | 174213 | 174214 | 174215 | 174216 | 174217 | 174218 | 174220 | 174221 | 174222 | 174223 | 174224 | 174225 | 174226 | 174248 | 174266 | 174267 | 174269 | 174270 | 174273 | 174327 | 174328 | 174329 | 174330 | 174331 | 174332 | 174333 | 174334 | 174335 | 174336 | 174337 | 174338 | 174339 | 174340 | 174341 | 174342 | 174343 | 174344 | 174345 | 174346 | 174347 | 174348 | 174349 | 174350 | 174351 | 174352 | 174353 | 174354 | 174355 | 174356 | 174357 | 174358 | 174359 | 174360 | 174603