Attachment 174204 Details for Bug 38010 – Bug 38010: Allow external breadcrumbs

[patch] Bug 38010: Allow external breadcrumbs

Bug-38010-Allow-external-breadcrumbs.patch (text/plain), 2.79 KB, created by Matt Blenkinsop on 2024-11-07 13:32:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-11-07 13:32:59 UTC

Size: 2.79 KB

patch

obsolete

>From c95f285300a41dea64d007174e6c7b2067bbed1e Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 24 Sep 2024 15:16:37 +0000
>Subject: [PATCH] Bug 38010: Allow external breadcrumbs
>
>This patch allows breadcrumbs to navigate to pages outside the Vue application
>---
> .../intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc    | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts    | 3 +++
> koha-tmpl/intranet-tmpl/prog/js/vue/routes/acquisitions.js     | 3 ++-
> 3 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc
>index 9614214a35d..bad05751232 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc
>@@ -30,7 +30,7 @@
>                 <div class="btn-group"><a class="btn btn-default" id="receive" href="/cgi-bin/koha/acqui/parcels.pl?booksellerid=[% booksellerid | html %]"><i class="fa fa-inbox"></i> Receive shipments</a></div>
>             [% END %]
>         [% ELSIF ( CAN_user_acquisition_vendors_manage ) %]
>-            <div class="btn-group"><a class="btn btn-default" href="/cgi-bin/koha/vendors"><i class="fa fa-plus"></i> New vendor</a></div>
>+            <div class="btn-group"><a class="btn btn-default" href="/cgi-bin/koha/vendors/add"><i class="fa fa-plus"></i> New vendor</a></div>
>         [% END %]
> </div>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts
>index 4305250a8fa..bdd1ae37330 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts
>@@ -62,4 +62,7 @@ const { removeMessages } = mainStore;
> router.beforeEach((to, from) => {
>     navigationStore.$patch({ current: to.matched, params: to.params || {} });
>     removeMessages(); // This will actually flag the messages as displayed already
>+    if (to.external || to.meta.self.parent.external) {
>+        window.location.href = to.path;
>+    }
> });
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/acquisitions.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/acquisitions.js
>index 33a9daf18be..f21f6381356 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/acquisitions.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/acquisitions.js
>@@ -9,7 +9,8 @@ import { $__ } from "../i18n";
> 
> export const routes = [
>     {
>-        path: "/cgi-bin/koha/acqui/booksellers.pl",
>+        path: "/cgi-bin/koha/acqui/acqui-home.pl",
>+        external: true,
>         is_default: true,
>         is_base: true,
>         title: $__("Acquisitions"),
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 38010: 174119 | 174120 | 174121 | 174122 | 174123 | 174124 | 174125 | 174126 | 174128 | 174129 | 174130 | 174131 | 174132 | 174133 | 174134 | 174135 | 174136 | 174137 | 174138 | 174139 | 174140 | 174141 | 174142 | 174143 | 174144 | 174145 | 174146 | 174147 | 174148 | 174151 | 174152 | 174153 | 174154 | 174155 | 174156 | 174157 | 174158 | 174159 | 174160 | 174161 | 174162 | 174163 | 174164 | 174165 | 174166 | 174167 | 174168 | 174169 | 174170 | 174171 | 174172 | 174173 | 174174 | 174175 | 174176 | 174177 | 174178 | 174179 | 174194 | 174196 | 174197 | 174198 | 174199 | 174200 | 174201 | 174202 | 174203 | 174204 | 174205 | 174206 | 174207 | 174208 | 174209 | 174210 | 174211 | 174212 | 174213 | 174214 | 174215 | 174216 | 174217 | 174218 | 174220 | 174221 | 174222 | 174223 | 174224 | 174225 | 174226 | 174248 | 174266 | 174267 | 174269 | 174270 | 174273 | 174327 | 174328 | 174329 | 174330 | 174331 | 174332 | 174333 | 174334 | 174335 | 174336 | 174337 | 174338 | 174339 | 174340 | 174341 | 174342 | 174343 | 174344 | 174345 | 174346 | 174347 | 174348 | 174349 | 174350 | 174351 | 174352 | 174353 | 174354 | 174355 | 174356 | 174357 | 174358 | 174359 | 174360 | 174603