Attachment 174302 Details for Bug 23674 – Bug 23674: Add ability to add a note to pay individual and write-off individual

[patch] Bug 23674: Add ability to add a note to pay individual and write-off individual

Bug-23674-Add-ability-to-add-a-note-to-pay-individ.patch (text/plain), 2.82 KB, created by Lucas Gass (lukeg) on 2024-11-08 21:38:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-08 21:38:26 UTC

Size: 2.82 KB

patch

obsolete

>From 34095134e5af99f418135ab8fb47707c9ba73b55 Mon Sep 17 00:00:00 2001
>From: Sam Lau <samalau@gmail.com>
>Date: Wed, 26 Jun 2024 18:10:47 +0000
>Subject: [PATCH] Bug 23674: Add ability to add a note to pay individual and
> write-off individual
>
>To test:
>1) Apply manual invoice to a patron account
>2) Go to the patron record -> accounting -> transaction tab
>3) Look for the "Pay" button under the actions column. Click this
>4) Notice no place to enter note
>5) Click the "Write off" button. Notice there is no place to enter note
>6) Apply patch, restart_all
>7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs.
>8) Write a not in the pay tab and confirm. Make sure this not shows up in the table.
>9) Add another invoice and then test the note functionallity for the write-offs.
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> .../prog/en/modules/members/paycollect.tt             | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>index 351a48cec20..06d2a2c8313 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>@@ -158,7 +158,6 @@
> 
> <fieldset class="rows">
>     <legend>Pay an individual charge</legend>
>-    <input type="hidden" name="payment_note" id="payment_note" value="[% payment_note | html %]" />
>     <table>
>     <thead><tr>
>             <th>Description</th>
>@@ -221,6 +220,11 @@
>         [% END %]
>     </li>
>     [% END %]
>+    <li>
>+        <label> Note: </label>
>+        <input name="payment_note" id="payment_note" value="[% payment_note | html %]" />
>+    </li>
>+
> </ol>
> </fieldset>
> 
>@@ -256,7 +260,6 @@
>     <input type="hidden" name="debit_type_code" id="debit_type_code" value="[% debit_type_code | html %]" />
>     <input type="hidden" name="amount" id="amount" value="[% amount | html %]" />
>     <input type="hidden" name="accountlines_id" id="accountlines_id" value="[% accountlines_id | html %]" />
>-    <input type="hidden" name="payment_note" id="payment_note" value="[% payment_note | html %]" />
>     <input type="hidden" name="amountoutstanding" id="amountoutstanding" value="[% amountoutstanding | html %]" />
>     <input type="hidden" name="change_given" id="change_given" />
>     <table>
>@@ -282,6 +285,10 @@
>                     
>                     <input name="paid" id="amountwrittenoff" value="[% amountoutstanding | $Price on_editing => 1 %]" type="text" />
>                 </li>
>+                <li>
>+                    <label> Note: </label>
>+                    <input name="payment_note" id="payment_note" value="[% payment_note | html %]" />
>+                </li>
>             </ol>
>         </fieldset>
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 23674: 168035 | 168036 | 168174 | 168177 | 168178 | 168180 | 168213 | 168329 | 168330 | 169782 | 169783 | 169784 | 169785 | 169786 | 169787 | 169788 | 174300 | 174301 | 174302 | 174303 | 174304 | 174305 | 174306 | 174307 | 174308