Bugzilla – Attachment 174317 Details for
Bug 38344
Don't send "Thank you !" as screen message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"
Bug-38344-Fix-typo---space-before-exclamation-mark.patch (text/plain), 1.04 KB, created by
David Nind
on 2024-11-10 19:27:33 UTC
(
hide
)
Description:
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-11-10 19:27:33 UTC
Size:
1.04 KB
patch
obsolete
>From 3975e6951be0058abd0e12a8f89522bbda879734 Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Sun, 10 Nov 2024 19:17:02 +0000 >Subject: [PATCH] Bug 38344: Fix typo - space before exclamation mark in "Thank > you !" > >In English, there should not be a space before an exclamation mark >in a sentence. For example, "Thank you !" is not correct. > >Test plan: >1. Search the codebase for "Thank you !": grep -rn "Thank you !" * >2. Result - one occurance: > C4/SIP/ILS.pm:317: return (1, 'Thank you !', ''); >3. Apply the patch. >4. Repeat step 1. >5. There should now be no occurances. > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/SIP/ILS.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 284b93a018..41b44bc7f8 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -320,7 +320,7 @@ sub end_patron_session { > my ($self, $patron_id) = @_; > > # success?, screen_msg, print_line >- return (1, 'Thank you !', ''); >+ return (1, 'Thank you!', ''); > } > > sub pay_fee { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38344
:
174317
|
174485
|
174534