Bugzilla – Attachment 174337 Details for
Bug 38010
Migrate vendors to Vue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38010: Remove drawCallback from contracts table
Bug-38010-Remove-drawCallback-from-contracts-table.patch (text/plain), 4.54 KB, created by
Matt Blenkinsop
on 2024-11-11 14:59:52 UTC
(
hide
)
Description:
Bug 38010: Remove drawCallback from contracts table
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-11-11 14:59:52 UTC
Size:
4.54 KB
patch
obsolete
>From d2a645691448336c3cb1e54bc015b276234a85aa Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 25 Sep 2024 15:09:28 +0000 >Subject: [PATCH] Bug 38010: Remove drawCallback from contracts table > >--- > .../components/Vendors/VendorContracts.vue | 45 +++++++++---------- > 1 file changed, 20 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue >index 3bece17a122..43adfba7cca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue >@@ -23,6 +23,7 @@ export default { > return { > isUserPermitted, > table_id, >+ escape_str, > } > }, > methods: { >@@ -51,7 +52,7 @@ export default { > data: "contractname", > searchable: false, > orderable: false, >- render(data, type, row, meta) { >+ render: function (data, type, row, meta) { > return ( > `<a href="/cgi-bin/koha/admin/aqcontract.pl?op=add_form&booksellerid=${row.booksellerid}&contractnumber=${row.contractnumber}">` + > escape_str(row.contractname) + >@@ -77,30 +78,24 @@ export default { > searchable: false, > orderable: false, > }, >- ...(isUserPermitted( >- "CAN_user_acquisition_contracts_manage" >- ) >- ? [ >- { >- title: __("Actions"), >- data: "contractnumber", >- searchable: false, >- orderable: false, >- render(data, type, row, meta) { >- return ( >- `<a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/aqcontract.pl?op=add_form&contractnumber=${row.contractnumber}&booksellerid=${row.booksellerid}"><i class="fa-solid fa-pencil" aria-hidden="true"></i>` + >- " " + >- __("Edit") + >- "</a>" + >- `<a style="margin-left: 5px;" class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/aqcontract.pl?op=delete_confirm&contractnumber=${row.contractnumber}&booksellerid=${row.booksellerid}"><i class="fa-solid fa-trash-can" aria-hidden="true"></i>` + >- " " + >- __("Delete") + >- "</a>" >- ) >- }, >- }, >- ] >- : []), >+ { >+ title: __("Actions"), >+ data: "contractnumber", >+ searchable: false, >+ orderable: false, >+ render: function (data, type, row, meta) { >+ return ( >+ `<a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/aqcontract.pl?op=add_form&contractnumber=${row.contractnumber}&booksellerid=${row.booksellerid}"><i class="fa-solid fa-pencil" aria-hidden="true"></i>` + >+ " " + >+ __("Edit") + >+ "</a>" + >+ `<a style="margin-left: 5px;" class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/aqcontract.pl?op=delete_confirm&contractnumber=${row.contractnumber}&booksellerid=${row.booksellerid}"><i class="fa-solid fa-trash-can" aria-hidden="true"></i>` + >+ " " + >+ __("Delete") + >+ "</a>" >+ ) >+ }, >+ }, > ], > }) > ) >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38010
:
174119
|
174120
|
174121
|
174122
|
174123
|
174124
|
174125
|
174126
|
174128
|
174129
|
174130
|
174131
|
174132
|
174133
|
174134
|
174135
|
174136
|
174137
|
174138
|
174139
|
174140
|
174141
|
174142
|
174143
|
174144
|
174145
|
174146
|
174147
|
174148
|
174151
|
174152
|
174153
|
174154
|
174155
|
174156
|
174157
|
174158
|
174159
|
174160
|
174161
|
174162
|
174163
|
174164
|
174165
|
174166
|
174167
|
174168
|
174169
|
174170
|
174171
|
174172
|
174173
|
174174
|
174175
|
174176
|
174177
|
174178
|
174179
|
174194
|
174196
|
174197
|
174198
|
174199
|
174200
|
174201
|
174202
|
174203
|
174204
|
174205
|
174206
|
174207
|
174208
|
174209
|
174210
|
174211
|
174212
|
174213
|
174214
|
174215
|
174216
|
174217
|
174218
|
174220
|
174221
|
174222
|
174223
|
174224
|
174225
|
174226
|
174248
|
174266
|
174267
|
174269
|
174270
|
174273
|
174327
|
174328
|
174329
|
174330
|
174331
|
174332
|
174333
|
174334
|
174335
|
174336
| 174337 |
174338
|
174339
|
174340
|
174341
|
174342
|
174343
|
174344
|
174345
|
174346
|
174347
|
174348
|
174349
|
174350
|
174351
|
174352
|
174353
|
174354
|
174355
|
174356
|
174357
|
174358
|
174359
|
174360
|
174603