Attachment 174348 Details for Bug 38010 – Bug 38010: Fix null basket names

[patch] Bug 38010: Fix null basket names

Bug-38010-Fix-null-basket-names.patch (text/plain), 2.17 KB, created by Matt Blenkinsop on 2024-11-11 15:00:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-11-11 15:00:29 UTC

Size: 2.17 KB

patch

obsolete

>From 5d94a7087815c7cfe29525b3b0238880c422885c Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 16 Oct 2024 09:39:11 +0100
>Subject: [PATCH] Bug 38010: Fix null basket names
>
>---
> .../prog/js/vue/components/Vendors/VendorBaskets.vue       | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorBaskets.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorBaskets.vue
>index 30541341db3..c896fbd65ce 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorBaskets.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorBaskets.vue
>@@ -117,11 +117,12 @@ export default {
>                     searchable: true,
>                     orderable: true,
>                     render(data, type, row, meta) {
>+                        const name = row.name ? row.name : __("Unnamed basket")
>                         return (
>                             '<a href="/cgi-bin/koha/acqui/basket.pl?basketno=' +
>                             row.basket_id +
>                             '" class="show">' +
>-                            escape_str(`${row.name} (#${row.basket_id})`) +
>+                            escape_str(`${name} (#${row.basket_id})`) +
>                             "</a>"
>                         )
>                     },
>@@ -139,7 +140,7 @@ export default {
>                         ).length
>                         if (cancelledOrders) {
>                             count +=
>-                                " (" + cancelledOrders + _(" cancelled") + ")"
>+                                " (" + cancelledOrders + __(" cancelled") + ")"
>                         }
>                         return count
>                     },
>@@ -176,7 +177,7 @@ export default {
>                             count +=
>                                 " (" +
>                                 recordCount.cancelledBibs.length +
>-                                _(" cancelled") +
>+                                __(" cancelled") +
>                                 ")"
>                         }
>                         return count
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 38010: 174119 | 174120 | 174121 | 174122 | 174123 | 174124 | 174125 | 174126 | 174128 | 174129 | 174130 | 174131 | 174132 | 174133 | 174134 | 174135 | 174136 | 174137 | 174138 | 174139 | 174140 | 174141 | 174142 | 174143 | 174144 | 174145 | 174146 | 174147 | 174148 | 174151 | 174152 | 174153 | 174154 | 174155 | 174156 | 174157 | 174158 | 174159 | 174160 | 174161 | 174162 | 174163 | 174164 | 174165 | 174166 | 174167 | 174168 | 174169 | 174170 | 174171 | 174172 | 174173 | 174174 | 174175 | 174176 | 174177 | 174178 | 174179 | 174194 | 174196 | 174197 | 174198 | 174199 | 174200 | 174201 | 174202 | 174203 | 174204 | 174205 | 174206 | 174207 | 174208 | 174209 | 174210 | 174211 | 174212 | 174213 | 174214 | 174215 | 174216 | 174217 | 174218 | 174220 | 174221 | 174222 | 174223 | 174224 | 174225 | 174226 | 174248 | 174266 | 174267 | 174269 | 174270 | 174273 | 174327 | 174328 | 174329 | 174330 | 174331 | 174332 | 174333 | 174334 | 174335 | 174336 | 174337 | 174338 | 174339 | 174340 | 174341 | 174342 | 174343 | 174344 | 174345 | 174346 | 174347 | 174348 | 174349 | 174350 | 174351 | 174352 | 174353 | 174354 | 174355 | 174356 | 174357 | 174358 | 174359 | 174360 | 174603