Attachment 17439 Details for Bug 9839 – Bug 9839 - when importing MARC records, item record not created even when set to "always add"

[patch] Bug 9839 - when importing MARC records, item record not created even when set to "always add"

Bug-9839---when-importing-MARC-records-item-record.patch (text/plain), 2.02 KB, created by Mason James on 2013-04-15 08:32:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2013-04-15 08:32:45 UTC

Size: 2.02 KB

patch

obsolete

>From aed6bf4e7abad22de538dd765f52930738fccba0 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 27 Mar 2013 13:57:01 -0400
>Subject: [PATCH] Bug 9839 - when importing MARC records, item record not created even when set to "always add"
>Content-Type: text/plain; charset="utf-8"
>
>Test Plan:
>1) Catalog a new record with an ISBN
>2) Add some items to the record
>3) Download the record as MARCXML
>4) Delete the itemnumbers from the 952 fields in the record,
>   Change the barcode fields to unused barcodes
>5) Use xml2marc to save as a standard MARC file
>6) Import the record using the 'Stage MARC for import' tool
>   Use the settings:
>       Record matching rule: ISBN
>       Action if matching record found: ignore
>       Action if no match found: ignore
>       Item processing: always_add
>       Check for embedded item record data?: Yes
>       How to process items: Always add items
>7) Import, note the bib is ignored, and the items are not processed
>8) Undo import into catalog
>8) Apply this patch
>9) Import this batch into the catalog
>10) Note the items were processed and are now added to the matching
>record
>
>Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
>Tested with UNIMARC record. I followed the test plan, just changing 952 by 995
>Signed-off-by: Mason James <mtj@kohaaloha.com>
>---
> C4/ImportBatch.pm |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index 5f46613..6185760 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -652,6 +652,7 @@ sub BatchCommitRecords {
>             SetImportRecordStatus($rowref->{'import_record_id'}, 'imported');
>         } elsif ($record_result eq 'ignore') {
>             $num_ignored++;
>+            $recordid = $record_match;
>             if ($record_type eq 'biblio' and defined $recordid and $item_result eq 'create_new') {
>                 my ($bib_items_added, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid);
>                 $num_items_added += $bib_items_added;
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 9839: 16308 | 16948 | 16952 | 17439