Bugzilla – Attachment 174435 Details for
Bug 38357
When adding new holidays Koha sometimes copies same holidays to other librarys
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38357: Prevent holidays to be wrongly added
Bug-38357-Prevent-holidays-to-be-wrongly-added.patch (text/plain), 1.51 KB, created by
Emily Lamancusa (emlam)
on 2024-11-12 18:18:48 UTC
(
hide
)
Description:
Bug 38357: Prevent holidays to be wrongly added
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-11-12 18:18:48 UTC
Size:
1.51 KB
patch
obsolete
>From 8b317f9dbeef7425cd7f9d5b553fa4553c226af7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Nov 2024 09:37:02 +0100 >Subject: [PATCH] Bug 38357: Prevent holidays to be wrongly added > >This patch resets @holiday_list to an empty array, to prevent holidays >to be accumulated in worker's memory. > >If you added single holidays to library A then others to library B, >holidays from A were also added to B. > >Test plan: >Go to /cgi-bin/koha/tools/holidays.pl >Define the holidays for Centerville > Select a date > To: another date (pick only 2 days to ease testing) > Set a title "cpl" > Tick "Holidays on a range" > Save >Define the holidays for Fairview > Select *another* date > To: another date (pick only 2 days to ease testing) > Set a title "fpl" > Tick "Holidays on a range" > Save > >=> Without this patch Fairview has 4 days of holidays instead of 2 >=> With this patch applied the dates you selected are considered >holidays for Fairview > >Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > tools/newHolidays.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/newHolidays.pl b/tools/newHolidays.pl >index c8215f1b4f..91d233b95f 100755 >--- a/tools/newHolidays.pl >+++ b/tools/newHolidays.pl >@@ -61,7 +61,7 @@ if ($description) { > } > > # We make an array with holiday's days >-our @holiday_list; >+our @holiday_list = (); > if ($end_dt){ > for (my $dt = $first_dt->clone(); > $dt <= $end_dt; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38357
:
173980
|
174065
|
174110
| 174435