Bugzilla – Attachment 174465 Details for
Bug 23426
Empty AV field returned in 'patron info' in addition to those requested
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23426: (follow-up) Enhance sip_cli_emulator.pl for test plan
Bug-23426-follow-up-Enhance-sipcliemulatorpl-for-t.patch (text/plain), 3.27 KB, created by
Martin Renvoize (ashimema)
on 2024-11-13 11:59:45 UTC
(
hide
)
Description:
Bug 23426: (follow-up) Enhance sip_cli_emulator.pl for test plan
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-11-13 11:59:45 UTC
Size:
3.27 KB
patch
obsolete
>From 6bb4ffa6d6772e17cff830b0275dfec5429de230 Mon Sep 17 00:00:00 2001 >From: Jan Kissig <bibliothek@th-wildau.de> >Date: Thu, 7 Nov 2024 13:32:05 +0000 >Subject: [PATCH] Bug 23426: (follow-up) Enhance sip_cli_emulator.pl for test > plan > >This follow up enhances the sip_cli_emulator.pl to use start-item and/or end-item as params. With these new params the original test plan can be extended: > >Test plan: >a) create several manual invoices for patron 23529000035676 : http://localhost:8081/cgi-bin/koha/members/maninvoice.pl?borrowernumber=19 >b) run > perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information -s " Y " --start-item=1 --end-item=2 > to get fine 1 and 2 or > perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information -s " Y " --start-item=3 --end-item=3 > to retrieve fine 3 > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > misc/sip_cli_emulator.pl | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > >diff --git a/misc/sip_cli_emulator.pl b/misc/sip_cli_emulator.pl >index dbb56537fe0..95ee8f5f569 100755 >--- a/misc/sip_cli_emulator.pl >+++ b/misc/sip_cli_emulator.pl >@@ -55,6 +55,8 @@ my $transaction_id; > my $pickup_location; > my $hold_mode; > my $no_block = 'N'; >+my $start_item; >+my $end_item; > > my $terminator = q{}; > >@@ -85,6 +87,8 @@ GetOptions( > "pickup-location=s" => \$pickup_location, > "hold-mode=s" => \$hold_mode, > "n|no-block=s" => \$no_block, >+ "start-item=s" => \$start_item, >+ "end-item=s" => \$end_item, > > "t|terminator=s" => \$terminator, > >@@ -158,8 +162,10 @@ my $handlers = { > terminal_password => $terminal_password, > patron_password => $patron_password, > summary => $summary, >+ start_item => $start_item, >+ end_item => $end_item, > }, >- optional => [ 'patron_password', 'summary' ], >+ optional => [ 'patron_password', 'summary', 'start_item', 'end_item' ], > }, > item_information => { > name => 'Item Information', >@@ -404,9 +410,13 @@ sub build_patron_information_command_message { > my $patron_identifier = $params->{patron_identifier}; > my $terminal_password = $params->{terminal_password}; > my $patron_password = $params->{patron_password}; >+ my $start_item = $params->{start_item}; >+ my $end_item = $params->{end_item}; > my $summary = $params->{summary}; > > $summary //= " "; >+ $start_item //= ""; >+ $end_item //= ""; > > return > PATRON_INFO >@@ -416,7 +426,9 @@ sub build_patron_information_command_message { > . build_field( FID_INST_ID, $institution_id ) > . build_field( FID_PATRON_ID, $patron_identifier ) > . build_field( FID_TERMINAL_PWD, $terminal_password ) >- . build_field( FID_PATRON_PWD, $patron_password, { optional => 1 } ); >+ . build_field( FID_PATRON_PWD, $patron_password, { optional => 1 } ) >+ . build_field( FID_START_ITEM, $start_item, { optional => 1 } ) >+ . build_field( FID_END_ITEM, $end_item, { optional => 1 } ); > } > > sub build_item_information_command_message { >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23426
:
91992
|
165507
|
165508
|
165509
|
165654
|
166240
|
169272
|
170931
|
172383
|
172384
|
174232
|
174233
|
174234
|
174464
| 174465 |
174479