Attachment 174489 Details for Bug 30745 – Bug 30745: Fix error 500 when item is not found while using zebra

[patch] Bug 30745: Fix error 500 when item is not found while using zebra

Bug-30745-Fix-error-500-when-item-is-not-found-whi.patch (text/plain), 1.36 KB, created by David Cook on 2024-11-14 05:58:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2024-11-14 05:58:27 UTC

Size: 1.36 KB

patch

obsolete

>From 8692e794b5a68fab0bc183a06e1c0d547e47c4f8 Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Mon, 26 Aug 2024 17:36:10 +0000
>Subject: [PATCH] Bug 30745: Fix error 500 when item is not found while using
> zebra
>
>Plan test :
>- Apply this batch
>- Set Zebra as searchEngine
>- Go to Cataloging -> # Label creator
>- Click on New, Select Label batch
>- Click on Add item(s)
>- Search for for inexisting items
>=> The page should refresh itself (so that it has the same behavior as elasticSearch)
>
>Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> labels/label-item-search.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/labels/label-item-search.pl b/labels/label-item-search.pl
>index 8cebec8278..765119f4f9 100755
>--- a/labels/label-item-search.pl
>+++ b/labels/label-item-search.pl
>@@ -85,7 +85,7 @@ if ( $op eq "do_search" ) {
>         undef, undef, $query_type, undef
>     );
> 
>-    if (!defined $error && @{$results->{biblioserver}{RECORDS}} ) {
>+    if (!defined $error && defined($results) && @{$results->{biblioserver}{RECORDS}} > 0 ) {
>         $show_results = grep { defined $_ } @{$results->{biblioserver}{RECORDS}};
>         $marcresults = [ grep { defined $_ } @{$results->{biblioserver}{RECORDS}} ];
>         $total_hits = $results->{biblioserver}{hits};
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 30745: 134952 | 134953 | 135784 | 135785 | 135966 | 135967 | 157192 | 157194 | 157195 | 157934 | 162855 | 163955 | 170677 | 170678 | 170679 | 170680 | 170681 | 170682 | 170683 | 170684 | 170729 | 170730 | 170731 | 170732 | 170733 | 171002 | 171003 | 171004 | 171005 | 171006 | 173280 | 173943 | 173944 | 173945 | 173946 | 173947 | 174486 | 174487 | 174488 | 174489 | 174490 | 174491