Bugzilla – Attachment 174502 Details for
Bug 36197
Allow unauthenticated ILL requests in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36197: Only check limits for regular requests
Bug-36197-Only-check-limits-for-regular-requests.patch (text/plain), 1.36 KB, created by
Pedro Amorim
on 2024-11-14 11:37:32 UTC
(
hide
)
Description:
Bug 36197: Only check limits for regular requests
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-11-14 11:37:32 UTC
Size:
1.36 KB
patch
obsolete
>From 24be446fc73916784aec7e6415d7125d9e22fd02 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 5 Mar 2024 17:07:01 +0000 >Subject: [PATCH] Bug 36197: Only check limits for regular requests > >Skip for unauthenticated requests > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/ILL/Request.pm | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 4bf239ce6a..e71255e398 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1031,18 +1031,14 @@ sub backend_create { > # ... complex case: commit! > > # Do we still have space for an ILL or should we queue? >- my $permitted = $self->check_limits( >- { patron => $self->patron }, { librarycode => $self->branchcode } >- ); >- >- # Now augment our committed request. >- >- $result->{permitted} = $permitted; # Queue request? >- >- # This involves... >- >- # ...Updating status! >- $self->status('QUEUED')->store unless ( $permitted ); >+ my $permitted = 1; >+ if( $self->patron ) { >+ $permitted = $self->check_limits( >+ { patron => $self->patron }, { librarycode => $self->branchcode } >+ ); >+ $result->{permitted} = $permitted; >+ $self->status('QUEUED')->store unless ($permitted); >+ } > > ## Handle Unmediated ILLs > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36197
:
171358
|
171359
|
171360
|
171361
|
171362
|
171363
|
171364
|
171365
|
171366
|
171367
|
171368
|
171369
|
171370
|
171371
|
174495
|
174496
|
174497
|
174498
|
174499
|
174500
|
174501
|
174502
|
174503
|
174504
|
174505
|
174506
|
174507
|
174508
|
176564
|
176565
|
176680
|
176723
|
176724
|
176726
|
176727
|
179764
|
179765
|
179766
|
179767
|
179769
|
179770
|
179771
|
179772
|
179773
|
179774
|
179775
|
179776
|
179777
|
179778
|
179779
|
179780
|
179781
|
179782
|
179783
|
179784
|
179785
|
180850
|
180851
|
180852
|
180853
|
180854
|
180855
|
180856
|
180857
|
180858
|
180859
|
180860
|
180861
|
180862
|
180863
|
180864
|
180865
|
180866
|
180867
|
180868
|
180869
|
180870
|
180871
|
180872
|
180873
|
181073
|
181074
|
181075
|
181076
|
181077
|
181078
|
181079
|
181080
|
181081
|
181082
|
181083
|
181084
|
181085
|
181086
|
181087
|
181088
|
181089
|
181090
|
181091
|
181092
|
181093
|
181094
|
181095
|
181096
|
181097
|
181098
|
181592