Attachment 174511 Details for Bug 33641 – Bug 33641: Code changes

[patch] Bug 33641: Code changes

Bug-33641-Code-changes.patch (text/plain), 1.22 KB, created by Nick Clemens (kidclamp) on 2024-11-14 12:44:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-11-14 12:44:29 UTC

Size: 1.22 KB

patch

obsolete

>From d8124b753d1b9357379480100397cc2e062809a5 Mon Sep 17 00:00:00 2001
>From: Eric Garcia <cubingguy714@gmail.com>
>Date: Tue, 6 Aug 2024 19:01:00 +0000
>Subject: [PATCH] Bug 33641: Code changes
>
>To test:
>
>1. Apply patch, restart_all, updatedatabase
>2. Check out an item to a patron
>3. Query the database
>    - select return_branch from issues;     should return NULL
>    - select branchcode from issues;        should return the branchcode of the library you checkout the item out from
>    - select return_branch from old_issues; should match the branchcode from the previous query
>
>Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index c15a8b3e96c..54d2feafa13 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2646,6 +2646,7 @@ sub MarkIssueReturned {
>             $issue->returndate( \'NOW()' )->store->discard_changes; # update and refetch
>         }
> 
>+        $issue->return_branch(C4::Context->userenv->{'branch'});
>         # Create the old_issues entry
>         my $old_checkout = Koha::Old::Checkout->new($issue->unblessed)->store;
> 
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 33641: 170105 | 170106 | 170107 | 170108 | 170109 | 170110 | 170111 | 170138 | 170139 | 170140 | 170141 | 173562 | 173563 | 173564 | 173565 | 174510 | 174511 | 174512 | 174513 | 174514 | 174536 | 174538 | 174569 | 174570 | 174571 | 174572 | 174573 | 174574 | 174584 | 174585