Attachment 174532 Details for Bug 37576 – Bug 37576: (follow-up) Fix for UserRoles test

[patch] Bug 37576: (follow-up) Fix for UserRoles test

Bug-37576-follow-up-Fix-for-UserRoles-test.patch (text/plain), 2.29 KB, created by Jake Deery on 2024-11-14 16:55:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jake Deery

Created: 2024-11-14 16:55:40 UTC

Size: 2.29 KB

patch

obsolete

>From 9ebc4b0375929c2256882a6e6f1532d507344b85 Mon Sep 17 00:00:00 2001
>From: Jake Deery <jake.deery@ptfs-europe.com>
>Date: Thu, 14 Nov 2024 16:53:52 +0000
>Subject: [PATCH] Bug 37576: (follow-up) Fix for UserRoles test
>
>This patch, although not directly caused by Bug 37576,
>fixes issues with the UserRoles cypress test due
>to a change in the data structure brought on by recent
>ERM bugs.
>---
> t/cypress/integration/ERM/UserRoles_spec.ts | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
>diff --git a/t/cypress/integration/ERM/UserRoles_spec.ts b/t/cypress/integration/ERM/UserRoles_spec.ts
>index db0224fabe3..4b9cb95e7de 100644
>--- a/t/cypress/integration/ERM/UserRoles_spec.ts
>+++ b/t/cypress/integration/ERM/UserRoles_spec.ts
>@@ -12,7 +12,6 @@ describe("Add/search user", () => {
>     });
> 
>     it("Add agreement", () => {
>-        let vendors = cy.get_vendors_to_relate();
>         // No agreement, no license yet
>         cy.intercept("GET", "/api/v1/erm/agreements*", {
>             statusCode: 200,
>@@ -31,15 +30,22 @@ describe("Add/search user", () => {
>                     patron_id: 1,
>                     firstname: "foo",
>                     surname: "bar",
>+                    preferred_name: "foo",
>                     category_id: "S",
>-                    library_id: "CPL",
>+                    library: {
>+                        library_id: "CPL",
>+                        name: "Centerville",
>+                    },
>                 },
>                 {
>                     patron_id: 2,
>                     firstname: "foofoo",
>                     surname: "barbar",
>                     category_id: "S",
>-                    library_id: "CPL",
>+                    library: {
>+                        library_id: "CPL",
>+                        name: "Centerville",
>+                    },
>                 },
>             ],
>             headers: {
>@@ -54,8 +60,12 @@ describe("Add/search user", () => {
>                 patron_id: 1,
>                 firstname: "foo",
>                 surname: "bar",
>+                preferred_name: "foo",
>                 category_id: "S",
>-                library_id: "CPL",
>+                library: {
>+                    library_id: "CPL",
>+                    name: "Centerville",
>+                },
>             },
>         });
> 
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 37576: 171181 | 171268 | 171379 | 171397 | 173774 | 173775 | 173776 | 174530 | 174531 | 174532